Bug 8507 – Compilation fixes for building on gcc 4.0.2, and without precomp headers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Kevin Ollivier]

This patch contains the fixes needed to build JSCore and WebCore on Win/Mac/Linux without precompiled headers, as well as fixes needed for gcc 4.0.2. It also resolves two minor issues with undefined behavior on non-supported platforms, specifically defining Unicode support to use ICU in all cases outside of KDE, and defining PlatformCursor to void* when it hasn't been defined by the platform yet.

[Kevin Ollivier]

Created attachment 7865 [details]
Patch for compilation fixes.

[Darin Adler]

Comment on attachment 7865 [details]
Patch for compilation fixes.

Looks good. I see three problems:

    1) The include for pthread.h should be !PLATFORM(WIN_OS), not !PLATFORM(WIN)

    2) Assertions.cpp should use <stdio.h>, <stdarg.h>, and <string.h>, not "stdio.h", etc.

    3) +#elseif defined(__APPLE__)

No such thing as #elseif. It's #elif.

That issue (3) seems serious enough that we should not land it, so r-. But if you fix those 3 things, then this looks good to go.

[Kevin Ollivier]

Created attachment 7867 [details]
Compilation fixes patch, with requested changes.

[Kevin Ollivier]

Thanks, I've made the changes you requested. Believe it or not, #3 actually does compile with at least gcc4, which is why I didn't catch it. 

[Darin Adler]

Comment on attachment 7867 [details]
Compilation fixes patch, with requested changes.

r=me