Bug 85065 - [Gtk][DOM Bindings] Conditional string in implementation file generated in wrong place after 113450
Summary: [Gtk][DOM Bindings] Conditional string in implementation file generated in wr...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
Depends on:
Reported: 2012-04-27 07:54 PDT by Zan Dobersek
Modified: 2012-04-27 09:26 PDT (History)
5 users (show)

See Also:

Patch (4.83 KB, patch)
2012-04-27 07:59 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2012-04-27 07:54:12 PDT
In revision 113450[1] the conditional string in implementation file was moved above the inclusion of WebCore (and other) headers. This reverts the reverse changes that were made in revision 111914, making builds again prone towards failure when disabling specific features (Geolocation for instance).

[1] http://trac.webkit.org/changeset/113450
[2] http://trac.webkit.org/changeset/111914
Comment 1 Zan Dobersek 2012-04-27 07:59:58 PDT
Created attachment 139202 [details]
Comment 2 Zan Dobersek 2012-04-27 09:26:26 PDT
Comment on attachment 139202 [details]

Clearing flags on attachment: 139202

Committed r115438: <http://trac.webkit.org/changeset/115438>
Comment 3 Zan Dobersek 2012-04-27 09:26:33 PDT
All reviewed patches have been landed.  Closing bug.