Bug 85056 - [Qt] Doesn't build with ENABLE_INSPECTOR=0
: [Qt] Doesn't build with ENABLE_INSPECTOR=0
Status: RESOLVED FIXED
: WebKit
WebKit2
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2012-04-27 06:00 PST by
Modified: 2012-05-14 07:01 PST (History)


Attachments
Patch (2.85 KB, patch)
2012-04-27 06:03 PST, Allan Sandfeld Jensen
no flags Review Patch | Details | Formatted Diff | Diff
Patch (5.90 KB, patch)
2012-04-27 06:24 PST, Allan Sandfeld Jensen
no flags Review Patch | Details | Formatted Diff | Diff
Patch (6.63 KB, patch)
2012-05-14 05:53 PST, Allan Sandfeld Jensen
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-04-27 06:00:48 PST
Build fails if we deactivate the inspector code, not something that is done by default, but easy to fix.
------- Comment #1 From 2012-04-27 06:03:25 PST -------
Created an attachment (id=139181) [details]
Patch
------- Comment #2 From 2012-04-27 06:19:44 PST -------
(From update of attachment 139181 [details])
Missing changes
------- Comment #3 From 2012-04-27 06:24:16 PST -------
Created an attachment (id=139187) [details]
Patch
------- Comment #4 From 2012-04-27 07:00:36 PST -------
(From update of attachment 139187 [details])
Attachment 139187 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12551212
------- Comment #5 From 2012-05-14 05:53:16 PST -------
Created an attachment (id=141703) [details]
Patch

Patch for landing
------- Comment #6 From 2012-05-14 07:01:04 PST -------
(From update of attachment 141703 [details])
Clearing flags on attachment: 141703

Committed r116944: <http://trac.webkit.org/changeset/116944>
------- Comment #7 From 2012-05-14 07:01:08 PST -------
All reviewed patches have been landed.  Closing bug.