Bug 85052 - [chromium] Disables a few webkit_unittests.
Summary: [chromium] Disables a few webkit_unittests.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Marcus Bulach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-27 05:03 PDT by Marcus Bulach
Modified: 2013-04-09 17:06 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.75 KB, patch)
2012-04-27 05:04 PDT, Marcus Bulach
no flags Details | Formatted Diff | Diff
Patch (2.98 KB, patch)
2012-04-27 08:04 PDT, Marcus Bulach
no flags Details | Formatted Diff | Diff
Patch (3.00 KB, patch)
2012-04-27 08:11 PDT, Marcus Bulach
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus Bulach 2012-04-27 05:03:16 PDT
[chromium] Disables a few webkit_unittests.
Comment 1 Marcus Bulach 2012-04-27 05:04:16 PDT
Created attachment 139173 [details]
Patch
Comment 2 Peter Beverloo 2012-04-27 05:06:28 PDT
SGTM.
Comment 3 WebKit Review Bot 2012-04-27 05:24:04 PDT
Comment on attachment 139173 [details]
Patch

Clearing flags on attachment: 139173

Committed r115421: <http://trac.webkit.org/changeset/115421>
Comment 4 WebKit Review Bot 2012-04-27 05:24:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Marcus Bulach 2012-04-27 08:04:53 PDT
Reopening to attach new patch.
Comment 6 Marcus Bulach 2012-04-27 08:04:56 PDT
Created attachment 139203 [details]
Patch
Comment 7 Peter Beverloo 2012-04-27 08:07:43 PDT
Please amend the ChangeLog descriptions to say why you are disabling them, because this isn't clear for anyone reading the logs. Thanks!
Comment 8 Marcus Bulach 2012-04-27 08:11:49 PDT
Created attachment 139206 [details]
Patch
Comment 9 Peter Beverloo 2012-04-27 08:12:20 PDT
SGTM.
Comment 10 Marcus Bulach 2012-04-27 08:14:12 PDT
Committed r115433: <http://trac.webkit.org/changeset/115433>
Comment 11 Dimitri Glazkov (Google) 2012-04-27 09:31:59 PDT
Reverted r115421 for reason:

Enable unit tests again.

Committed r115440: <http://trac.webkit.org/changeset/115440>
Comment 12 Dimitri Glazkov (Google) 2012-04-27 09:33:43 PDT
Reverted r115433 for reason:

Enable unit tests again.

Committed r115441: <http://trac.webkit.org/changeset/115441>
Comment 13 Stephen Chenney 2013-04-09 17:06:05 PDT
Marked LayoutTest bugs, bugs with Chromium IDs, and some others as WontFix. Test failure bugs still are trackable via TestExpectations or disabled unit tests.