Bug 85048 – [EFL] ewk_view navigation_policy_decision() input parameters should be extended

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Mikhail Pozdnyakov]

ewk_view navigation_policy_decision() input parameters should be extended with navigation type info in order to provide 
needed logging for bug85006

[Mikhail Pozdnyakov]

Created attachment 139172 [details]
new parameter for ewk_view navigation_policy_decision()

[Mikhail Pozdnyakov]

Created attachment 139174 [details]
new parameter for ewk_view navigation_policy_decision()

[Gyuyoung Kim]

Comment on attachment 139174 [details]
new parameter for ewk_view navigation_policy_decision()

Looks good to me.

[Antonio Gomes]

Comment on attachment 139174 [details]
new parameter for ewk_view navigation_policy_decision()

View in context: https://bugs.webkit.org/attachment.cgi?id=139174&action=review

> Source/WebKit/efl/ChangeLog:13
> +        [EFL] ewk_view navigation_policy_decision() input parameters should be extended
> +        https://bugs.webkit.org/show_bug.cgi?id=85048
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Introduced new enum Ewk_Navigation_Type cloning WebCore::NavigationType.
> +        Extended ewk_view navigation_policy_decision() input parameters with new
> +        navigationType parameter.
> +
> +        * WebCoreSupport/AssertMatchingEnums.cpp:
> +        * WebCoreSupport/FrameLoaderClientEfl.cpp:

I think you could say why it is needed.

[Antonio Gomes]

View in context: https://bugs.webkit.org/attachment.cgi?id=139174&action=review

> Source/WebKit/efl/ChangeLog:13
> +        [EFL] ewk_view navigation_policy_decision() input parameters should be extended
> +        https://bugs.webkit.org/show_bug.cgi?id=85048
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Introduced new enum Ewk_Navigation_Type cloning WebCore::NavigationType.
> +        Extended ewk_view navigation_policy_decision() input parameters with new
> +        navigationType parameter.
> +
> +        * WebCoreSupport/AssertMatchingEnums.cpp:
> +        * WebCoreSupport/FrameLoaderClientEfl.cpp:

I think you could say why it is needed.

[Mikhail Pozdnyakov]

Created attachment 141402 [details]
new parameter for ewk_view navigation_policy_decision()

[Mikhail Pozdnyakov]

(In reply to comment #5)
> View in context: https://bugs.webkit.org/attachment.cgi?id=139174&action=review
> 
> > Source/WebKit/efl/ChangeLog:13
> > +        [EFL] ewk_view navigation_policy_decision() input parameters should be extended
> > +        https://bugs.webkit.org/show_bug.cgi?id=85048
> > +
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +        Introduced new enum Ewk_Navigation_Type cloning WebCore::NavigationType.
> > +        Extended ewk_view navigation_policy_decision() input parameters with new
> > +        navigationType parameter.
> > +
> > +        * WebCoreSupport/AssertMatchingEnums.cpp:
> > +        * WebCoreSupport/FrameLoaderClientEfl.cpp:
> 
> I think you could say why it is needed.
Fixed.

[WebKit Review Bot]

Comment on attachment 141402 [details]
new parameter for ewk_view navigation_policy_decision()

Rejecting attachment 141402 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
1 FAILED at 245.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/efl/ewk/ewk_private.h.rej
patching file Source/WebKit/efl/ewk/ewk_view.cpp
Hunk #1 succeeded at 3994 (offset 91 lines).
Hunk #2 succeeded at 4004 (offset 91 lines).
patching file Source/WebKit/efl/ewk/ewk_view.h
Hunk #1 succeeded at 179 (offset 1 line).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antonio Go..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12727459

[Mikhail Pozdnyakov]

Created attachment 142900 [details]
to be landed.

[WebKit Review Bot]

Comment on attachment 142900 [details]
to be landed.

Clearing flags on attachment: 142900

Committed r117720: <http://trac.webkit.org/changeset/117720>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.