Bug 85047 - [EFL][DRT] EFL should sanitize pulseaudio module configuration too
: [EFL][DRT] EFL should sanitize pulseaudio module configuration too
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit EFL
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Dominik Röttsches (drott)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-27 04:17 PDT by Dominik Röttsches (drott)
Modified: 2012-04-27 13:06 PDT (History)
8 users (show)

See Also:


Attachments
Moving pulseaudio unload/restore to shared class (11.23 KB, patch)
2012-04-27 04:35 PDT, Dominik Röttsches (drott)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Röttsches (drott) 2012-04-27 04:17:17 PDT
We would like to reuse the GTK pulseaudio sanitization.
Comment 1 Dominik Röttsches (drott) 2012-04-27 04:35:31 PDT
Created attachment 139168 [details]
Moving pulseaudio unload/restore to shared class

Feedback from GTK folks is very welcome.
Comment 2 Dirk Pranke 2012-04-27 11:43:45 PDT
Comment on attachment 139168 [details]
Moving pulseaudio unload/restore to shared class

I'm R+'ing this because you presumably didn't write this code and are just moving it around, but the code should really be using the FileSystem and Executive classes, and have some unit tests rather than talking to os.path and subprocess directly :(.
Comment 3 WebKit Review Bot 2012-04-27 13:06:44 PDT
Comment on attachment 139168 [details]
Moving pulseaudio unload/restore to shared class

Clearing flags on attachment: 139168

Committed r115478: <http://trac.webkit.org/changeset/115478>
Comment 4 WebKit Review Bot 2012-04-27 13:06:49 PDT
All reviewed patches have been landed.  Closing bug.