Bug 85047 - [EFL][DRT] EFL should sanitize pulseaudio module configuration too
: [EFL][DRT] EFL should sanitize pulseaudio module configuration too
Status: RESOLVED FIXED
: WebKit
WebKit EFL
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2012-04-27 04:17 PST by
Modified: 2012-04-27 13:06 PST (History)


Attachments
Moving pulseaudio unload/restore to shared class (11.23 KB, patch)
2012-04-27 04:35 PST, Dominik Röttsches (drott)
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-04-27 04:17:17 PST
We would like to reuse the GTK pulseaudio sanitization.
------- Comment #1 From 2012-04-27 04:35:31 PST -------
Created an attachment (id=139168) [details]
Moving pulseaudio unload/restore to shared class

Feedback from GTK folks is very welcome.
------- Comment #2 From 2012-04-27 11:43:45 PST -------
(From update of attachment 139168 [details])
I'm R+'ing this because you presumably didn't write this code and are just moving it around, but the code should really be using the FileSystem and Executive classes, and have some unit tests rather than talking to os.path and subprocess directly :(.
------- Comment #3 From 2012-04-27 13:06:44 PST -------
(From update of attachment 139168 [details])
Clearing flags on attachment: 139168

Committed r115478: <http://trac.webkit.org/changeset/115478>
------- Comment #4 From 2012-04-27 13:06:49 PST -------
All reviewed patches have been landed.  Closing bug.