Bug 85046 - [EFL] Add OwnPtr specialization for Eina_Hash.
Summary: [EFL] Add OwnPtr specialization for Eina_Hash.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 74921
  Show dependency tree / graph
 
Reported: 2012-04-27 03:19 PDT by Michal Pakula vel Rutka
Modified: 2012-05-10 07:04 PDT (History)
3 users (show)

See Also:

Attachments
proposed patch (1.66 KB, patch)
2012-04-27 03:22 PDT, Michal Pakula vel Rutka 		no flags Details | Formatted Diff | Diff
fixed order (1.81 KB, patch)
2012-05-07 02:21 PDT, Michal Pakula vel Rutka 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Pakula vel Rutka 2012-04-27 03:19:26 PDT 
OwnPtr does not have as support for Eina_Hash, this patch adds implementation so it can be used by https://bugs.webkit.org/show_bug.cgi?id=74921.
Comment 1 Michal Pakula vel Rutka 2012-04-27 03:22:06 PDT 
Created attachment 139164 [details]
proposed patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-04-28 12:09:47 PDT 
Comment on attachment 139164 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139164&action=review

> Source/WTF/wtf/OwnPtrCommon.h:47
> +typedef struct _Eina_Hash Eina_Hash;

Please keep this list (as well as the others) sorted.
Comment 3 Michal Pakula vel Rutka 2012-05-07 02:21:22 PDT 
Created attachment 140496 [details]
fixed order

Fixed alphabetical order in OwnPtrCommon.h and moved new method above other Eina_* method as order is not kept there.
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-05-09 10:51:45 PDT 
LGTM.
Comment 5 Gyuyoung Kim 2012-05-09 21:58:20 PDT 
Comment on attachment 140496 [details]
fixed order

Looks good. Thanks.
Comment 6 Raphael Kubo da Costa (:rakuco) 2012-05-10 07:04:15 PDT 
Comment on attachment 140496 [details]
fixed order

Clearing flags on attachment: 140496

Committed r116640: <http://trac.webkit.org/changeset/116640>
Comment 7 Raphael Kubo da Costa (:rakuco) 2012-05-10 07:04:25 PDT 
All reviewed patches have been landed.  Closing bug.