The Spec: ====================================== 4.12.4 Downloading resources In some cases, resources are intended for later use rather than immediate viewing. To indicate that a resource is intended to be downloaded for use later, rather than immediately used, the download attribute can be specified on the a or area element that creates the hyperlink to that resource. The attribute can furthermore be given a value, to specify the filename that user agents are to use when storing the resource in a file system. This value can be overridden by the Content-Disposition HTTP header's filename parameters. [RFC6266] Steps to Reproduce: ======================================= 1. Navigate to http://updates.html5rocks.com/2011/08/Downloading-resources-in-HTML5-a-download with PlayBook browser 2. Click the "download me" hyper-link in the page. The HTML for it: <a href="http://www.google.com/.../logo2w.png" download="MyGoogleLogo">download me</a> Expected result: ======================================= The download dialogue will pop up with file name as "MyGoogleLogo.png", which is the value of the download attribute.
Created attachment 139163 [details] Patch
setSuggestSaveName should be setSuggestedSaveName. Too tired to look at the rest right now.
(In reply to comment #1) > Created an attachment (id=139163) [details] > Patch Looks good to me.
Mary, did you test CrossThreadResourceRequestData or redirect?
(In reply to comment #4) > Mary, did you test CrossThreadResourceRequestData or redirect? Good catch - the new member variable needs to be added to that too. Also I just noticed it's missing m_overrideContentType and m_targetType.
(In reply to comment #5) > (In reply to comment #4) > > Mary, did you test CrossThreadResourceRequestData or redirect? > > Good catch - the new member variable needs to be added to that too. Also I just noticed it's missing m_overrideContentType and m_targetType. thanks, will add in CrossThreadResourceRequestData. also for the missing members, will create separate pr to track.
Created attachment 139936 [details] Patch
LGTM
Comment on attachment 139936 [details] Patch Rejecting attachment 139936 [details] from commit-queue. mary.wu@torchmobile.com.cn does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Comment on attachment 139936 [details] Patch Rejecting attachment 139936 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ED at 244. 2 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp.rej patching file Source/WebKit/blackberry/Api/WebPage.cpp patching file Source/WebKit/blackberry/Api/WebPage_p.h patching file Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antonio Go..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12507050
Created attachment 140462 [details] Patch
Comment on attachment 140462 [details] Patch Clearing flags on attachment: 140462 Committed r116265: <http://trac.webkit.org/changeset/116265>
All reviewed patches have been landed. Closing bug.