Bug 85030 - [chromium] Separate IOSurface layer type from texture layers
: [chromium] Separate IOSurface layer type from texture layers
Product: WebKit
Classification: Unclassified
Component: New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: James Robinson
Depends on:
  Show dependency treegraph
Reported: 2012-04-26 22:29 PDT by James Robinson
Modified: 2012-04-27 20:37 PDT (History)
6 users (show)

See Also:

Patch (51.88 KB, patch)
2012-04-26 22:32 PDT, James Robinson
enne: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-04-26 22:29:02 PDT
[chromium] Separate IOSurface layer type from texture layers
Comment 1 James Robinson 2012-04-26 22:32:19 PDT
Created attachment 139133 [details]
Comment 2 WebKit Review Bot 2012-04-26 22:34:39 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 WebKit Review Bot 2012-04-26 22:35:01 PDT
Attachment 139133 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1
Source/WebKit/chromium/src/WebIOSurfaceLayer.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 20 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Adrienne Walker 2012-04-27 10:53:18 PDT
Comment on attachment 139133 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=139133&action=review


> Source/WebCore/platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:52
> +    // FIXME: it seems there is no layer renderer / GraphicsContext3D available here. Ideally we
> +    // would like to delete m_ioSurfaceTextureId.

This feels kind of like a job for TextureManager/ManagedTexture, but those classes aren't quite smart enough to handle IO surface textures.
Comment 5 James Robinson 2012-04-27 20:37:05 PDT
It's a "normal" texture, just needs a deleteTexture() call.
Comment 6 James Robinson 2012-04-27 20:37:36 PDT