Remove RegisterFile::end()/m_end
Created attachment 139087 [details] Patch
Comment on attachment 139087 [details] Patch Attachment 139087 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12534029
Comment on attachment 139087 [details] Patch Attachment 139087 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12548026
Comment on attachment 139087 [details] Patch Attachment 139087 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12552041
Created attachment 139090 [details] Remove now bogus NDEBUG ifdef
Committed r115388: <http://trac.webkit.org/changeset/115388>
This patch seems to have caused massive swings in number of tests in http://webkit-perf.appspot.com on all JSC using (Mac Lion and Qt) bots. 10% regression in Dromaeo/dom-traverse: http://webkit-perf.appspot.com/graph.html#tests=[[40020,2001,32196]]&sel=1335481319023.587,1335500151119.3953,1212.7659574468084,2680.851063829787&displayrange=7&datatype=running 50% regression in DOM/Template http://webkit-perf.appspot.com/graph.html#tests=[[110,2001,32196]]&sel=1335480730398.3186,1335502455543.162,6.808510638297875,30.638297872340424&displayrange=7&datatype=running 50% progression in Bindings/event-target-wrapper (Lion bot only, not Qt bots) http://webkit-perf.appspot.com/graph.html#tests=[[8062,2001,32196]]&sel=1335478825629.3184,1335502278508.2844,0,1468.0851063829787&displayrange=7&datatype=running
(In reply to comment #7) > This patch seems to have caused massive swings in number of tests in http://webkit-perf.appspot.com on all JSC using (Mac Lion and Qt) bots. > > 10% regression in Dromaeo/dom-traverse: > > http://webkit-perf.appspot.com/graph.html#tests=[[40020,2001,32196]]&sel=1335481319023.587,1335500151119.3953,1212.7659574468084,2680.851063829787&displayrange=7&datatype=running > > 50% regression in DOM/Template > > http://webkit-perf.appspot.com/graph.html#tests=[[110,2001,32196]]&sel=1335480730398.3186,1335502455543.162,6.808510638297875,30.638297872340424&displayrange=7&datatype=running > > 50% progression in Bindings/event-target-wrapper (Lion bot only, not Qt bots) > > http://webkit-perf.appspot.com/graph.html#tests=[[8062,2001,32196]]&sel=1335478825629.3184,1335502278508.2844,0,1468.0851063829787&displayrange=7&datatype=running That is certainly sad making. Could you file a separate bug on that, assign it to me -- i'll look into it on monday. Doesn't make sense that this would cause any variation (if anything it should reduce variation, and improve overall performance. grumble.
Filed bug 85155.
Reverted r115388 for reason: This caused many weird performance problems, and needs to be landed in pieces. Committed r115861: <http://trac.webkit.org/changeset/115861>