Bug 85010 - Improve compositing logging output
Summary: Improve compositing logging output
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
Depends on:
Reported: 2012-04-26 14:51 PDT by Simon Fraser (smfr)
Modified: 2012-04-26 18:39 PDT (History)
4 users (show)

See Also:

Patch (12.22 KB, patch)
2012-04-26 14:58 PDT, Simon Fraser (smfr)
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-04-26 14:51:05 PDT
Improve compositing logging output
Comment 1 Simon Fraser (smfr) 2012-04-26 14:53:27 PDT
Sample output:

Update 25 of main frame. Overlap testing is off
 0x118243338 1150x14002 0.000MP (root) RenderView
     0x121c51b88 769x902 0.000MP (clips compositing descendants) RenderBlock (relative positioned) DIV 'map'
         0x1280b9248 1280x1536 1.966MP (transform) RenderBlock (positioned) DIV
         0x12a2e52a8 0x0 0.000MP (overlap/stacking) RenderBlock (positioned) DIV
         0x12a2e5718 0x0 0.000MP (overlap/stacking) RenderBlock (positioned) DIV
         0x12a2e5b88 0x0 0.000MP (overlap/stacking) RenderBlock (positioned) DIV
         0x12a2e5ff8 0x0 0.000MP (overlap/stacking) RenderBlock (positioned) DIV
         0x12a2e6468 0x0 0.000MP (overlap/stacking) RenderBlock (positioned) DIV
         0x12a2e68d8 0x0 0.000MP (overlap/stacking) RenderBlock (positioned) DIV
         0x12a2e6d48 0x0 0.000MP (overlap/stacking) RenderBlock (positioned) DIV
         0x12a2e71b8 0x0 0.000MP (overlap/stacking) RenderBlock (positioned) DIV
       0x1186982f8 83x152 0.013MP (overlap/stacking) RenderBlock (positioned) DIV 'views-control'
       0x1186a3d58 19x19 0.000MP (overlap/stacking) RenderBlock (positioned) DIV 'map_overview'
       0x12859e378 390x19 0.007MP (overlap/stacking) RenderBlock (positioned) DIV 'copyright'
       0x11d3ae718 43x29 0.000MP (overlap/stacking) RenderBlock (positioned) DIV 'map_magnifyingglass'
       0x12859eae8 110x29 0.003MP (overlap/stacking) RenderBlock (positioned) DIV 'scalecontrol'
       0x1282aacc8 90x339 0.031MP (overlap/stacking) RenderBlock (positioned) DIV 'lmc3d'
     0x1186a7108 1150x1 0.001MP (overlap/stacking) RenderBlock (positioned) DIV
     0x1186a7b38 1150x2 0.002MP (overlap/stacking) RenderBlock (positioned) DIV
     0x1186a8568 1150x3 0.003MP (overlap/stacking) RenderBlock (positioned) DIV
     0x1186a8f98 1150x4 0.005MP (overlap/stacking) RenderBlock (positioned) DIV
     0x1186a99c8 1150x5 0.006MP (overlap/stacking) RenderBlock (positioned) DIV
     0x1186aa908 1x900 0.001MP (overlap/stacking) RenderBlock (positioned) DIV
     0x1186ab3a8 2x900 0.002MP (overlap/stacking) RenderBlock (positioned) DIV
     0x1186abe48 3x900 0.003MP (overlap/stacking) RenderBlock (positioned) DIV
     0x1186ac8e8 4x900 0.004MP (overlap/stacking) RenderBlock (positioned) DIV
     0x1186ad388 5x900 0.004MP (overlap/stacking) RenderBlock (positioned) DIV
     0x118677688 381x59 0.022MP (overlap/stacking) RenderBlock (relative positioned) DIV 'topbar'
     0x1186ade78 381x845 0.322MP (overlap/stacking) RenderBlock (positioned) DIV 'panel'
     0x121dcb508 1150x102 0.117MP (overlap/stacking) RenderBlock (relative positioned) DIV
     0x1186594b8 1150x0 0.000MP (overlap/stacking) RenderBlock (relative positioned) DIV 'infoarea'
Total layers   primary   secondary   obligatory backing (MP)   secondary backing(MP)   total backing (MP)  update time (ms)
      31           3        28                 1.97                   0.55                   2.51               7.71
Comment 2 Simon Fraser (smfr) 2012-04-26 14:58:10 PDT
Created attachment 139078 [details]
Comment 3 Dean Jackson 2012-04-26 15:23:50 PDT
Comment on attachment 139078 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=139078&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:459
> +    LOG(Compositing, "%*p %dx%d %.3fMP (%s) %s\n", 12 + depth * 2, layer, backing->compositedBounds().width(), backing->compositedBounds().height(),

maybe depth * 4 to be webkit stylish?

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1456
> +        return "transform-style: preserve-3d";

I think just "preserve-3d" is enough.
Comment 4 Simon Fraser (smfr) 2012-04-26 18:39:28 PDT