Bug 84996 - Fix missing sourceState change on MEDIA_ERR_SOURCE_NOT_SUPPORTED error.
Summary: Fix missing sourceState change on MEDIA_ERR_SOURCE_NOT_SUPPORTED error.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aaron Colwell
Depends on:
Blocks: 83607
  Show dependency treegraph
Reported: 2012-04-26 13:04 PDT by Aaron Colwell
Modified: 2012-04-26 15:33 PDT (History)
3 users (show)

See Also:

Patch (11.64 KB, patch)
2012-04-26 13:09 PDT, Aaron Colwell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Colwell 2012-04-26 13:04:07 PDT
In cases where appending data with webkitSourceAppend() triggers a MEDIA_ERR_SOURCE_NOT_SUPPORTED error, the m_sourceState was not being reset to SOURCE_CLOSED. This was causing future calls to webkitSourceAppend() after the error to actually make calls to m_player->sourceAppend() instead of throwing an INVALID_STATE_ERR exception like they were supposed to. 

This was causing crashes in Chromium because the code assumes that once it reports the error to WebKit it won't get any more calls to m_player->sourceAppend().
Comment 1 Aaron Colwell 2012-04-26 13:09:09 PDT
Created attachment 139052 [details]
Comment 2 WebKit Review Bot 2012-04-26 15:33:31 PDT
Comment on attachment 139052 [details]

Clearing flags on attachment: 139052

Committed r115380: <http://trac.webkit.org/changeset/115380>
Comment 3 WebKit Review Bot 2012-04-26 15:33:36 PDT
All reviewed patches have been landed.  Closing bug.