WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
84991
Add a test for crash in DOMSelection::deleteFromDocument
https://bugs.webkit.org/show_bug.cgi?id=84991
Summary
Add a test for crash in DOMSelection::deleteFromDocument
Ryosuke Niwa
Reported
2012-04-26 12:35:09 PDT
We need a test for the
bug 44153
.
Attachments
Adds a regression test
(2.26 KB, patch)
2012-04-26 13:03 PDT
,
Ryosuke Niwa
ap
: review+
ap
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2012-04-26 13:03:52 PDT
Created
attachment 139050
[details]
Adds a regression test
Alexey Proskuryakov
Comment 2
2012-04-26 13:16:31 PDT
Comment on
attachment 139050
[details]
Adds a regression test View in context:
https://bugs.webkit.org/attachment.cgi?id=139050&action=review
> LayoutTests/editing/selection/deleteFromDocument-after-document-open-crash.html:25 > + layoutTestController.notifyDone();
This test doesn't appear to need waitUntilDone/notifyDone - all the work is done from unload.
Ryosuke Niwa
Comment 3
2012-04-26 13:18:00 PDT
Comment on
attachment 139050
[details]
Adds a regression test View in context:
https://bugs.webkit.org/attachment.cgi?id=139050&action=review
>> LayoutTests/editing/selection/deleteFromDocument-after-document-open-crash.html:25 >> + layoutTestController.notifyDone(); > > This test doesn't appear to need waitUntilDone/notifyDone - all the work is done from unload.
document.open() sometimes ends DRT so without this, the test will be flaky.
Alexey Proskuryakov
Comment 4
2012-04-26 13:32:10 PDT
> document.open() sometimes ends DRT so without this, the test will be flaky.
How can this possibly be non-deterministic? Is there an uninitialized variable somewhere? Looks like you're covering up a real bug.
Ryosuke Niwa
Comment 5
2012-04-26 13:37:49 PDT
(In reply to
comment #4
)
> > document.open() sometimes ends DRT so without this, the test will be flaky. > > How can this possibly be non-deterministic? Is there an uninitialized variable somewhere? > > Looks like you're covering up a real bug.
Maybe. The last time I checked, this was expected behavior per spec and non-determinism was due to some race conditions. But then I'm not too familiar with this area.
Ryosuke Niwa
Comment 6
2012-04-26 14:06:38 PDT
Hm... it appears that this problem no longer reproduces at least on this test. I'm gonna just remove waitUntilDone/notifyDone for now.
Ryosuke Niwa
Comment 7
2012-04-26 14:09:26 PDT
Committed
r115360
: <
http://trac.webkit.org/changeset/115360
>
Alexey Proskuryakov
Comment 8
2012-04-26 16:30:47 PDT
> it appears that this problem no longer reproduces at least on this test
Perhaps it's more complicated when the script runs during load, as opposed to unload handler.
Ryosuke Niwa
Comment 9
2012-04-26 16:48:25 PDT
(In reply to
comment #8
)
> > it appears that this problem no longer reproduces at least on this test > > Perhaps it's more complicated when the script runs during load, as opposed to unload handler.
Hm... that's possible. I guess Chromium WebKit gardeners will notice if this test becomes flaky :)
Alexey Proskuryakov
Comment 10
2012-04-26 17:20:02 PDT
> unload
onload, thank you autocorrection :)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug