Bug 84985 – Counter still gets incremented when counter-increment is set to none

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Yi Shen]

http://test.csswg.org/suites/css2.1/20110323/html4/counter-increment-053.htm test fails. According to w3c spec (http://www.w3.org/TR/CSS2/generate.html#propdef-counter-increment), A value of 'none' on its own means no counters are reset, resp. incremented.

[Yi Shen]

Created attachment 139048 [details]
First try

[Brent Fulgham]

Comment on attachment 139048 [details]
First try

This patch looks correct. Is there a reason it has not been reviewed? Does it violate some aspect of the counter specification?

[Tony Chang]

Elliott was in the counters code recently, maybe he would like to do an unofficial review?

[Elliott Sprehn]

I'll review later today, but looking quickly this doesn't seem right since you transform none into counter-increment: 0 for every counter which creates implicit scopes.

[Yi Shen]

Thanks for comments, guys. It is an old patch and I will rework on it.
(In reply to comment #4)
> I'll review later today, but looking quickly this doesn't seem right since you transform none into counter-increment: 0 for every counter which creates implicit scopes.

[Julien Chaffraix]

Comment on attachment 139048 [details]
First try

Punting the patch out of the review queue based on Elliot's comment. If you come up with a new patch covering implicit scopes, I would be happy to look at it.

[Yi Shen]

Created attachment 194371 [details]
clear counter increment when its value is none

[WebKit Commit Bot]

Comment on attachment 194371 [details]
clear counter increment when its value is none

Clearing flags on attachment: 194371

Committed r147930: <http://trac.webkit.org/changeset/147930>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.