Bug 84969 - Implement StyleSheetInternal copying
Summary: Implement StyleSheetInternal copying
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 77745
  Show dependency treegraph
Reported: 2012-04-26 09:08 PDT by Antti Koivisto
Modified: 2012-04-26 11:44 PDT (History)
4 users (show)

See Also:

patch (12.97 KB, patch)
2012-04-26 10:37 PDT, Antti Koivisto
kling: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2012-04-26 09:08:32 PDT
We need to be able to copy stylesheets to cache them. Copying is already implement for most of the stylesheet data types but StyleSheetInternal::copy() is still missing.
Comment 1 Antti Koivisto 2012-04-26 10:37:08 PDT
Created attachment 139025 [details]
Comment 2 Early Warning System Bot 2012-04-26 10:49:05 PDT
Comment on attachment 139025 [details]

Attachment 139025 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12525915
Comment 3 Andreas Kling 2012-04-26 11:21:09 PDT
Comment on attachment 139025 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=139025&action=review

r=me with GCC appeased somehow.

> Source/WebCore/ChangeLog:8
> +        We need to be able to copy stylesheets to cache them. Copying is already implement for

Typo, implemented.

> Source/WebCore/ChangeLog:28
> +            Add equality comparison operator to CSSParseMode. This will be needed to determine

Typo CSSParserMode.
Comment 4 Antti Koivisto 2012-04-26 11:44:26 PDT
http://trac.webkit.org/changeset/115336 (with a build fix)