Top copy CSSSelectorList correctly CSSSelector needs a copy constructor.
Created attachment 139001 [details] patch
Attachment 139001 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/CSSSelector.h:40: The parameter name "o" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/css/CSSSelector.h:246: The parameter name "o" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 139001 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=139001&action=review > Source/WebCore/ChangeLog:8 > + To copy CSSSelectorLists correctly CSSSelector needs a copy constructor. Maybe you should explain the why, the real objective in this first patch.
Comment on attachment 139001 [details] patch Attachment 139001 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12530950
Comment on attachment 139001 [details] patch Attachment 139001 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12543094
Created attachment 139003 [details] fix build
http://trac.webkit.org/changeset/115319