Bug 84956 - Add copy constructor to CSSSelector
Summary: Add copy constructor to CSSSelector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 77745
  Show dependency treegraph
 
Reported: 2012-04-26 07:37 PDT by Antti Koivisto
Modified: 2012-04-26 08:56 PDT (History)
4 users (show)

See Also:


Attachments
patch (6.91 KB, patch)
2012-04-26 07:43 PDT, Antti Koivisto
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
fix build (6.96 KB, patch)
2012-04-26 08:04 PDT, Antti Koivisto
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2012-04-26 07:37:44 PDT
Top copy CSSSelectorList correctly CSSSelector needs a copy constructor.
Comment 1 Antti Koivisto 2012-04-26 07:43:43 PDT
Created attachment 139001 [details]
patch
Comment 2 WebKit Review Bot 2012-04-26 07:46:21 PDT
Attachment 139001 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/CSSSelector.h:40:  The parameter name "o" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/css/CSSSelector.h:246:  The parameter name "o" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexis Menard (darktears) 2012-04-26 07:50:12 PDT
Comment on attachment 139001 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139001&action=review

> Source/WebCore/ChangeLog:8
> +        To copy CSSSelectorLists correctly CSSSelector needs a copy constructor.

Maybe you should explain the why, the real objective in this first patch.
Comment 4 Early Warning System Bot 2012-04-26 07:59:30 PDT
Comment on attachment 139001 [details]
patch

Attachment 139001 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12530950
Comment 5 Build Bot 2012-04-26 08:04:22 PDT
Comment on attachment 139001 [details]
patch

Attachment 139001 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12543094
Comment 6 Antti Koivisto 2012-04-26 08:04:53 PDT
Created attachment 139003 [details]
fix build
Comment 7 Antti Koivisto 2012-04-26 08:56:54 PDT
http://trac.webkit.org/changeset/115319