Bug 84951 - Move WebKit1 specific conversion of touch-events to WebKit1
Summary: Move WebKit1 specific conversion of touch-events to WebKit1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-26 06:38 PDT by Allan Sandfeld Jensen
Modified: 2012-04-27 05:01 PDT (History)
3 users (show)

See Also:


Attachments
Patch (14.61 KB, patch)
2012-04-26 06:42 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff
Patch (2.87 KB, patch)
2012-04-27 02:28 PDT, Allan Sandfeld Jensen
kenneth: review+
kenneth: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-04-26 06:38:00 PDT
The WebKit1 specific conversion of touch-events is currently residing in WebCore/platform/qt. It should be moved to WebKit1/WebCoreSupport/WebEventConversion.cpp where the similar conversion of mouse and wheel events have been moved.
Comment 1 Allan Sandfeld Jensen 2012-04-26 06:42:30 PDT
Created attachment 138988 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-04-26 06:52:47 PDT
Comment on attachment 138988 [details]
Patch

Makes sense
Comment 3 WebKit Review Bot 2012-04-26 07:29:32 PDT
Comment on attachment 138988 [details]
Patch

Clearing flags on attachment: 138988

Committed r115312: <http://trac.webkit.org/changeset/115312>
Comment 4 WebKit Review Bot 2012-04-26 07:29:36 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Csaba Osztrogonác 2012-04-26 11:30:48 PDT
Reopen, because it broke the --minimal build:

../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:224: error: invalid use of incomplete type 'struct WebCore::PlatformTouchEvent'
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.h:36: error: forward declaration of 'struct WebCore::PlatformTouchEvent'
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:229: error: expected class-name before '{' token
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:231: error: 'State' has not been declared
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp: In constructor 'WebCore::WebKitPlatformTouchEvent::WebKitPlatformTouchEvent(QTouchEvent*)':
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:238: error: 'm_type' was not declared in this scope
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:238: error: 'TouchStart' is not a member of 'WebCore::PlatformEvent'
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:241: error: 'TouchMove' is not a member of 'WebCore::PlatformEvent'
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:244: error: 'TouchEnd' is not a member of 'WebCore::PlatformEvent'
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:255: error: 'PlatformTouchPoint' has not been declared
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:255: error: expected ';' before 'state'
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:259: error: 'state' was not declared in this scope
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:259: error: 'PlatformTouchPoint' has not been declared
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:262: error: 'PlatformTouchPoint' has not been declared
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:265: error: 'PlatformTouchPoint' has not been declared
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:268: error: 'PlatformTouchPoint' has not been declared
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:274: error: 'm_type' was not declared in this scope
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:274: error: 'TouchCancel' is not a member of 'WebCore::PlatformEvent'
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:275: error: 'state' was not declared in this scope
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:275: error: 'PlatformTouchPoint' has not been declared
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:277: error: 'm_touchPoints' was not declared in this scope
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:277: error: 'state' was not declared in this scope
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:280: error: 'm_modifiers' was not declared in this scope
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:282: error: 'm_timestamp' was not declared in this scope
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp: At global scope:
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:285: error: 'State' has not been declared
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp: In constructor 'WebCore::WebKitPlatformTouchPoint::WebKitPlatformTouchPoint(const QTouchEvent::TouchPoint&, int)':
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:288: error: 'm_id' was not declared in this scope
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:289: error: 'm_state' was not declared in this scope
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:290: error: 'm_screenPos' was not declared in this scope
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:291: error: 'm_pos' was not declared in this scope
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:295: error: 'm_radiusX' was not declared in this scope
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:296: error: 'm_radiusY' was not declared in this scope
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:299: error: 'm_radiusX' was not declared in this scope
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:300: error: 'm_radiusY' was not declared in this scope
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:302: error: 'm_force' was not declared in this scope
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp: In function 'WebCore::PlatformTouchEvent WebCore::convertTouchEvent(QTouchEvent*)':
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:316: error: return type 'struct WebCore::PlatformTouchEvent' is incomplete
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:316: error: new declaration 'void WebCore::convertTouchEvent(QTouchEvent*)'
../../../Source/WebKit/qt/WebCoreSupport/WebEventConversion.h:42: error: ambiguates old declaration 'WebCore::PlatformTouchEvent WebCore::convertTouchEvent(QTouchEvent*)'


Could you check what happened?
Comment 6 Allan Sandfeld Jensen 2012-04-27 02:28:04 PDT
Created attachment 139154 [details]
Patch
Comment 7 Kristóf Kosztyó 2012-04-27 05:01:51 PDT
Committed r115420: <http://trac.webkit.org/changeset/115420>