Bug 84950 - [GTK] Massive media tests failures since r115288
Summary: [GTK] Massive media tests failures since r115288
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-26 06:34 PDT by Philippe Normand
Modified: 2012-06-26 14:25 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.58 KB, patch)
2012-04-26 12:20 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2012-04-26 06:34:17 PDT
Lots of tests now timing out. It seems the GStreamer media player does something wrong which has bad consequences on the memory management of the media elements.

This works fine:

run-webkit-tests --run-singly --gtk media

But when the DRT instance is reused acrossed tests (default behavior) it triggers unexpected flakiness of the media suite.
Comment 1 Mark Hahnenberg 2012-04-26 08:02:31 PDT
I believe this has to do with the fact that we only have a properly implemented GCActivityCallback on platforms which have CoreFoundation, meaning we are now not doing any collection for those platforms without CoreFoundation when we call GCController::garbageCollectSoon(). This is obviously bad. 

I'd imagine that this issue manifests itself in the media tests because of the fact that they're dealing with very large things that need to be collected pretty quickly when they die to prevent memory bloat.
Comment 2 Mark Hahnenberg 2012-04-26 12:20:48 PDT
Created attachment 139040 [details]
Patch
Comment 3 Philippe Normand 2012-04-26 12:52:45 PDT
I've just tested the patch locally and it fixes the media suite flakyness. Thanks Mark!
Comment 4 WebKit Review Bot 2012-04-26 15:52:53 PDT
Comment on attachment 139040 [details]
Patch

Clearing flags on attachment: 139040

Committed r115383: <http://trac.webkit.org/changeset/115383>
Comment 5 WebKit Review Bot 2012-04-26 15:52:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Yong Li 2012-06-26 14:22:25 PDT
How about moving Timer/SharedTimer into WTF as is done for String?
Comment 7 Mark Hahnenberg 2012-06-26 14:25:19 PDT
(In reply to comment #6)
> How about moving Timer/SharedTimer into WTF as is done for String?

Yes, that is what I'd like to do when I get around to it. If you'd like to do that, you're more than welcome! :-)