Bug 84948 - [Qt][WK2] Tap highlight should have a delay not to interfere with panning
: [Qt][WK2] Tap highlight should have a delay not to interfere with panning
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: All Linux
: P3 Normal
Assigned To:
:
: Qt
:
:
  Show dependency treegraph
 
Reported: 2012-04-26 06:22 PST by
Modified: 2012-04-26 07:14 PST (History)


Attachments
proposed patch (6.77 KB, patch)
2012-04-26 06:41 PST, Andras Becsi
no flags Review Patch | Details | Formatted Diff | Diff
proposed patch (6.71 KB, patch)
2012-04-26 06:47 PST, Andras Becsi
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-04-26 06:22:25 PST
Start the tap highlight animation after a slight delay so that pan gestures do not result in flashing highlight rects which slow down flicking, especially for continuous pan gestures.
------- Comment #1 From 2012-04-26 06:41:53 PST -------
Created an attachment (id=138987) [details]
proposed patch
------- Comment #2 From 2012-04-26 06:47:49 PST -------
Created an attachment (id=138990) [details]
proposed patch
------- Comment #3 From 2012-04-26 06:56:06 PST -------
(From update of attachment 138990 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=138990&action=review

> Source/WebKit2/UIProcess/qt/QtTapGestureRecognizer.cpp:102
> +void QtTapGestureRecognizer::tapHighlightTimeout()

We are in the TAP gesture recognizer,,,.. maybe highlightTimeout is sufficient

> Source/WebKit2/UIProcess/qt/QtTapGestureRecognizer.h:39
> +const int tapHighlightThreshold = 80;

highlightPostponeTime would make more sense

> Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:499
> +        // Early return since this was a touch end event.

touch-end event
------- Comment #4 From 2012-04-26 07:14:00 PST -------
Landed in http://trac.webkit.org/changeset/115311.
------- Comment #5 From 2012-04-26 07:14:19 PST -------
(From update of attachment 138990 [details])
Clearing flags.