Bug 84948 - [Qt][WK2] Tap highlight should have a delay not to interfere with panning
Summary: [Qt][WK2] Tap highlight should have a delay not to interfere with panning
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P3 Normal
Assignee: Andras Becsi
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2012-04-26 06:22 PDT by Andras Becsi
Modified: 2012-04-26 07:14 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch (6.77 KB, patch)
2012-04-26 06:41 PDT, Andras Becsi 		no flags Details | Formatted Diff | Diff
proposed patch (6.71 KB, patch)
2012-04-26 06:47 PDT, Andras Becsi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Becsi 2012-04-26 06:22:25 PDT 
Start the tap highlight animation after a slight delay so that pan gestures do not result in flashing highlight rects which slow down flicking, especially for continuous pan gestures.
Comment 1 Andras Becsi 2012-04-26 06:41:53 PDT 
Created attachment 138987 [details]
proposed patch
Comment 2 Andras Becsi 2012-04-26 06:47:49 PDT 
Created attachment 138990 [details]
proposed patch
Comment 3 Kenneth Rohde Christiansen 2012-04-26 06:56:06 PDT 
Comment on attachment 138990 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138990&action=review

> Source/WebKit2/UIProcess/qt/QtTapGestureRecognizer.cpp:102
> +void QtTapGestureRecognizer::tapHighlightTimeout()

We are in the TAP gesture recognizer,,,.. maybe highlightTimeout is sufficient

> Source/WebKit2/UIProcess/qt/QtTapGestureRecognizer.h:39
> +const int tapHighlightThreshold = 80;

highlightPostponeTime would make more sense

> Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:499
> +        // Early return since this was a touch end event.

touch-end event
Comment 4 Andras Becsi 2012-04-26 07:14:00 PDT 
Landed in http://trac.webkit.org/changeset/115311.
Comment 5 Andras Becsi 2012-04-26 07:14:19 PDT 
Comment on attachment 138990 [details]
proposed patch

Clearing flags.