Patch to follow. Upstreaming http://code.google.com/p/chromium/issues/detail?id=121423
Created attachment 139012 [details] Patch
Comment on attachment 139012 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139012&action=review > Source/WebCore/inspector/Inspector.json:340 > + "name": "scriptExecutionStatus", getScriptExecutionStatus ? > Source/WebCore/inspector/InspectorPageAgent.cpp:727 > + settings->setScriptEnabled(!value); Will this change be reflected in the browser settings? > Source/WebCore/inspector/front-end/SettingsScreen.js:43 > + p = this._appendSection(WebInspector.UIString("General")); Please merge it with var p; above.
Committed r115323: <http://trac.webkit.org/changeset/115323>
Committed r115417: <http://trac.webkit.org/changeset/115417>
After the patch Qt SnowLeopard Release bot got warnings: /usr/local/Trolltech/Qt-4.8.1/include/QtCore/qobject.h:113:163: warning: explicitly assigning a variable of type 'int' to itself [-Wself-assign] /usr/local/Trolltech/Qt-4.8.1/include/QtCore/qiodevice.h:72:163: warning: explicitly assigning a variable of type 'int' to itself [-Wself-assign] http://build.webkit.org/builders/Qt%20SnowLeopard%20Release/builds/11076
(In reply to comment #5) > After the patch Qt SnowLeopard Release bot got warnings: > > /usr/local/Trolltech/Qt-4.8.1/include/QtCore/qobject.h:113:163: warning: explicitly assigning a variable of type 'int' to itself [-Wself-assign] > /usr/local/Trolltech/Qt-4.8.1/include/QtCore/qiodevice.h:72:163: warning: explicitly assigning a variable of type 'int' to itself [-Wself-assign] > > http://build.webkit.org/builders/Qt%20SnowLeopard%20Release/builds/11076 Clearly, warnings in Qt system includes are not caused by this patch...
Reverted r115417 for reason: Added test is broken on windows. Committed r115445: <http://trac.webkit.org/changeset/115445>
(In reply to comment #7) > Reverted r115417 for reason: > > Added test is broken on windows. > > Committed r115445: <http://trac.webkit.org/changeset/115445> Patch with corrected test re-landed as http://trac.webkit.org/changeset/115447
This should not have been marked as r+ - it adds public methods that we did not agree on supporting further. Please follow up with the "hidden" attribute.