Bug 84946 – Web Inspector: Implement the "Disable JavaScript" option in the settings dialog

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexander Pavlov (apavlov)]

Patch to follow.

Upstreaming http://code.google.com/p/chromium/issues/detail?id=121423

[Alexander Pavlov (apavlov)]

Created attachment 139012 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 139012 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139012&action=review

> Source/WebCore/inspector/Inspector.json:340
> +                "name": "scriptExecutionStatus",

getScriptExecutionStatus ?

> Source/WebCore/inspector/InspectorPageAgent.cpp:727
> +        settings->setScriptEnabled(!value);

Will this change be reflected in the browser settings?

> Source/WebCore/inspector/front-end/SettingsScreen.js:43
> +    p = this._appendSection(WebInspector.UIString("General"));

Please merge it with var p; above.

[Alexander Pavlov (apavlov)]

Committed r115323: <http://trac.webkit.org/changeset/115323>

[Alexander Pavlov (apavlov)]

Committed r115417: <http://trac.webkit.org/changeset/115417>

[Zoltan Arvai]

After the patch Qt SnowLeopard Release bot got warnings:

/usr/local/Trolltech/Qt-4.8.1/include/QtCore/qobject.h:113:163: warning: explicitly assigning a variable of type 'int' to itself [-Wself-assign]
/usr/local/Trolltech/Qt-4.8.1/include/QtCore/qiodevice.h:72:163: warning: explicitly assigning a variable of type 'int' to itself [-Wself-assign]

http://build.webkit.org/builders/Qt%20SnowLeopard%20Release/builds/11076

[Alexander Pavlov (apavlov)]

(In reply to comment #5)
> After the patch Qt SnowLeopard Release bot got warnings:
> 
> /usr/local/Trolltech/Qt-4.8.1/include/QtCore/qobject.h:113:163: warning: explicitly assigning a variable of type 'int' to itself [-Wself-assign]
> /usr/local/Trolltech/Qt-4.8.1/include/QtCore/qiodevice.h:72:163: warning: explicitly assigning a variable of type 'int' to itself [-Wself-assign]
> 
> http://build.webkit.org/builders/Qt%20SnowLeopard%20Release/builds/11076

Clearly, warnings in Qt system includes are not caused by this patch...

[Dimitri Glazkov (Google)]

Reverted r115417 for reason:

Added test is broken on windows.

Committed r115445: <http://trac.webkit.org/changeset/115445>

[Alexander Pavlov (apavlov)]

(In reply to comment #7)
> Reverted r115417 for reason:
> 
> Added test is broken on windows.
> 
> Committed r115445: <http://trac.webkit.org/changeset/115445>

Patch with corrected test re-landed as http://trac.webkit.org/changeset/115447

[Pavel Feldman]

This should not have been marked as r+ - it adds public methods that we did not agree on supporting further. Please follow up with the "hidden" attribute.