WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
84946
Web Inspector: Implement the "Disable JavaScript" option in the settings dialog
https://bugs.webkit.org/show_bug.cgi?id=84946
Summary
Web Inspector: Implement the "Disable JavaScript" option in the settings dialog
Alexander Pavlov (apavlov)
Reported
2012-04-26 05:07:56 PDT
Patch to follow. Upstreaming
http://code.google.com/p/chromium/issues/detail?id=121423
Attachments
Patch
(15.32 KB, patch)
2012-04-26 08:53 PDT
,
Alexander Pavlov (apavlov)
yurys
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1
2012-04-26 08:53:12 PDT
Created
attachment 139012
[details]
Patch
Yury Semikhatsky
Comment 2
2012-04-26 09:34:22 PDT
Comment on
attachment 139012
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=139012&action=review
> Source/WebCore/inspector/Inspector.json:340 > + "name": "scriptExecutionStatus",
getScriptExecutionStatus ?
> Source/WebCore/inspector/InspectorPageAgent.cpp:727 > + settings->setScriptEnabled(!value);
Will this change be reflected in the browser settings?
> Source/WebCore/inspector/front-end/SettingsScreen.js:43 > + p = this._appendSection(WebInspector.UIString("General"));
Please merge it with var p; above.
Alexander Pavlov (apavlov)
Comment 3
2012-04-26 09:44:05 PDT
Committed
r115323
: <
http://trac.webkit.org/changeset/115323
>
Alexander Pavlov (apavlov)
Comment 4
2012-04-27 03:06:52 PDT
Committed
r115417
: <
http://trac.webkit.org/changeset/115417
>
Zoltan Arvai
Comment 5
2012-04-27 05:05:57 PDT
After the patch Qt SnowLeopard Release bot got warnings: /usr/local/Trolltech/Qt-4.8.1/include/QtCore/qobject.h:113:163: warning: explicitly assigning a variable of type 'int' to itself [-Wself-assign] /usr/local/Trolltech/Qt-4.8.1/include/QtCore/qiodevice.h:72:163: warning: explicitly assigning a variable of type 'int' to itself [-Wself-assign]
http://build.webkit.org/builders/Qt%20SnowLeopard%20Release/builds/11076
Alexander Pavlov (apavlov)
Comment 6
2012-04-27 05:24:00 PDT
(In reply to
comment #5
)
> After the patch Qt SnowLeopard Release bot got warnings: > > /usr/local/Trolltech/Qt-4.8.1/include/QtCore/qobject.h:113:163: warning: explicitly assigning a variable of type 'int' to itself [-Wself-assign] > /usr/local/Trolltech/Qt-4.8.1/include/QtCore/qiodevice.h:72:163: warning: explicitly assigning a variable of type 'int' to itself [-Wself-assign] > >
http://build.webkit.org/builders/Qt%20SnowLeopard%20Release/builds/11076
Clearly, warnings in Qt system includes are not caused by this patch...
Dimitri Glazkov (Google)
Comment 7
2012-04-27 09:52:12 PDT
Reverted
r115417
for reason: Added test is broken on windows. Committed
r115445
: <
http://trac.webkit.org/changeset/115445
>
Alexander Pavlov (apavlov)
Comment 8
2012-05-18 06:46:43 PDT
(In reply to
comment #7
)
> Reverted
r115417
for reason: > > Added test is broken on windows. > > Committed
r115445
: <
http://trac.webkit.org/changeset/115445
>
Patch with corrected test re-landed as
http://trac.webkit.org/changeset/115447
Pavel Feldman
Comment 9
2013-01-20 23:06:30 PST
This should not have been marked as r+ - it adds public methods that we did not agree on supporting further. Please follow up with the "hidden" attribute.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug