Bug 84946 - Web Inspector: Implement the "Disable JavaScript" option in the settings dialog
Summary: Web Inspector: Implement the "Disable JavaScript" option in the settings dialog
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on: 84975
Blocks: 82737
  Show dependency treegraph
 
Reported: 2012-04-26 05:07 PDT by Alexander Pavlov (apavlov)
Modified: 2013-01-20 23:06 PST (History)
12 users (show)

See Also:


Attachments
Patch (15.32 KB, patch)
2012-04-26 08:53 PDT, Alexander Pavlov (apavlov)
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2012-04-26 05:07:56 PDT
Patch to follow.

Upstreaming http://code.google.com/p/chromium/issues/detail?id=121423
Comment 1 Alexander Pavlov (apavlov) 2012-04-26 08:53:12 PDT
Created attachment 139012 [details]
Patch
Comment 2 Yury Semikhatsky 2012-04-26 09:34:22 PDT
Comment on attachment 139012 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139012&action=review

> Source/WebCore/inspector/Inspector.json:340
> +                "name": "scriptExecutionStatus",

getScriptExecutionStatus ?

> Source/WebCore/inspector/InspectorPageAgent.cpp:727
> +        settings->setScriptEnabled(!value);

Will this change be reflected in the browser settings?

> Source/WebCore/inspector/front-end/SettingsScreen.js:43
> +    p = this._appendSection(WebInspector.UIString("General"));

Please merge it with var p; above.
Comment 3 Alexander Pavlov (apavlov) 2012-04-26 09:44:05 PDT
Committed r115323: <http://trac.webkit.org/changeset/115323>
Comment 4 Alexander Pavlov (apavlov) 2012-04-27 03:06:52 PDT
Committed r115417: <http://trac.webkit.org/changeset/115417>
Comment 5 Zoltan Arvai 2012-04-27 05:05:57 PDT
After the patch Qt SnowLeopard Release bot got warnings:

/usr/local/Trolltech/Qt-4.8.1/include/QtCore/qobject.h:113:163: warning: explicitly assigning a variable of type 'int' to itself [-Wself-assign]
/usr/local/Trolltech/Qt-4.8.1/include/QtCore/qiodevice.h:72:163: warning: explicitly assigning a variable of type 'int' to itself [-Wself-assign]

http://build.webkit.org/builders/Qt%20SnowLeopard%20Release/builds/11076
Comment 6 Alexander Pavlov (apavlov) 2012-04-27 05:24:00 PDT
(In reply to comment #5)
> After the patch Qt SnowLeopard Release bot got warnings:
> 
> /usr/local/Trolltech/Qt-4.8.1/include/QtCore/qobject.h:113:163: warning: explicitly assigning a variable of type 'int' to itself [-Wself-assign]
> /usr/local/Trolltech/Qt-4.8.1/include/QtCore/qiodevice.h:72:163: warning: explicitly assigning a variable of type 'int' to itself [-Wself-assign]
> 
> http://build.webkit.org/builders/Qt%20SnowLeopard%20Release/builds/11076

Clearly, warnings in Qt system includes are not caused by this patch...
Comment 7 Dimitri Glazkov (Google) 2012-04-27 09:52:12 PDT
Reverted r115417 for reason:

Added test is broken on windows.

Committed r115445: <http://trac.webkit.org/changeset/115445>
Comment 8 Alexander Pavlov (apavlov) 2012-05-18 06:46:43 PDT
(In reply to comment #7)
> Reverted r115417 for reason:
> 
> Added test is broken on windows.
> 
> Committed r115445: <http://trac.webkit.org/changeset/115445>

Patch with corrected test re-landed as http://trac.webkit.org/changeset/115447
Comment 9 Pavel Feldman 2013-01-20 23:06:30 PST
This should not have been marked as r+ - it adds public methods that we did not agree on supporting further. Please follow up with the "hidden" attribute.