Bug 84944 - [EFL] [DRT] Unskip passing tests related to editing commands
Summary: [EFL] [DRT] Unskip passing tests related to editing commands
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sudarsana Nagineni (babu)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-26 04:43 PDT by Sudarsana Nagineni (babu)
Modified: 2012-04-27 16:22 PDT (History)
4 users (show)

See Also:


Attachments
patch (4.47 KB, patch)
2012-04-26 04:49 PDT, Sudarsana Nagineni (babu)
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cq-02 (6.14 MB, application/zip)
2012-04-27 09:59 PDT, WebKit Review Bot
no flags Details
Patch (deleted)
2012-04-27 12:41 PDT, Sudarsana Nagineni (babu)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sudarsana Nagineni (babu) 2012-04-26 04:43:04 PDT
Many tests related to editing commands are passing now on EFL port. I am going to unksip them from the skip list.
Comment 1 Sudarsana Nagineni (babu) 2012-04-26 04:49:57 PDT
Created attachment 138978 [details]
patch

Unskip passing tests
Comment 2 Sudarsana Nagineni (babu) 2012-04-26 05:00:27 PDT
Checked on two machines, no regressions found.
Comment 3 WebKit Review Bot 2012-04-27 09:59:41 PDT
Comment on attachment 138978 [details]
patch

Rejecting attachment 138978 [details] from commit-queue.

New failing tests:
fast/workers/storage/interrupt-database.html
Full output: http://queues.webkit.org/results/12559258
Comment 4 WebKit Review Bot 2012-04-27 09:59:47 PDT
Created attachment 139220 [details]
Archive of layout-test-results from ec2-cq-02

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: ec2-cq-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 5 Sudarsana Nagineni (babu) 2012-04-27 12:20:11 PDT
I don't understand what went wrong. Tested again on my machine and no regression found.

Without patch:
=> Results: 21188/29312 tests passed (72.3%)
=> Tests to be fixed (8124):
      1 crash                    ( 0.0%)
    195 text diff mismatch       ( 2.4%)
     29 image mismatch           ( 0.4%)
   7899 skipped                  (97.2%)
Expected to fail, but passed: (4)
Unexpected flakiness: text diff mismatch (1)
Regressions: Unexpected text diff mismatch : (132)
Regressions: Unexpected image mismatch : (9)
Regressions: Unexpected crashes : (1)

With patch:
=> Results: 21248/29312 tests passed (72.5%)
=> Tests to be fixed (8064):
      1 crash                    ( 0.0%)
    195 text diff mismatch       ( 2.4%)
     29 image mismatch           ( 0.4%)
   7839 skipped                  (97.2%)
Expected to fail, but passed: (4)
Unexpected flakiness: text diff mismatch (1)
Regressions: Unexpected text diff mismatch : (132)
Regressions: Unexpected image mismatch : (9)
Regressions: Unexpected crashes : (1)
Comment 6 Sudarsana Nagineni (babu) 2012-04-27 12:41:38 PDT
Created attachment 139249 [details]
Patch

trying again
Comment 7 WebKit Review Bot 2012-04-27 16:22:27 PDT
Comment on attachment 139249 [details]
Patch

Clearing flags on attachment: 139249

Committed r115511: <http://trac.webkit.org/changeset/115511>
Comment 8 WebKit Review Bot 2012-04-27 16:22:40 PDT
All reviewed patches have been landed.  Closing bug.