Bug 84943 - [EFL] Several media layout tests need rebaselining
Summary: [EFL] Several media layout tests need rebaselining
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 84949
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-26 04:29 PDT by Chris Dumez
Modified: 2012-05-06 22:54 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.77 KB, patch)
2012-04-26 04:32 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (5.50 KB, patch)
2012-04-27 11:19 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (5.50 KB, patch)
2012-04-27 11:23 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-04-26 04:29:36 PDT
The following media tests are failing and seem to require rebaselining:
  - media/media-controls-clone.html
  - media/video-empty-source.html
  - media/video-zoom-controls.html = TEXT
Comment 1 Chris Dumez 2012-04-26 04:32:52 PDT
Created attachment 138976 [details]
Patch
Comment 2 Chris Dumez 2012-04-26 06:27:03 PDT
Comment on attachment 138976 [details]
Patch

Removing cq? flag since it will require further rebaselining once media/video-controls-rendering-toggle-display-none.html is fixed.
Comment 3 Chris Dumez 2012-04-26 06:45:37 PDT
These tests need rebaselining because of bug 82150 fix.
Comment 4 Chris Dumez 2012-04-27 11:19:37 PDT
Created attachment 139238 [details]
Patch
Comment 5 Chris Dumez 2012-04-27 11:23:00 PDT
Created attachment 139240 [details]
Patch

Improve bug report title.
Comment 6 Eric Carlson 2012-04-27 11:36:38 PDT
Did you forget to set the r? flag?
Comment 7 Chris Dumez 2012-04-27 12:29:22 PDT
Is formal review needed for simple rebaselining?
Comment 8 Eric Carlson 2012-04-27 13:24:39 PDT
(In reply to comment #7)
> Is formal review needed for simple rebaselining?

No, but I don't know that I have ever seen a bug with only cq? so I wasn't sure if you actually meant to set it. 

I would probably be a good idea to leave a comment in a bug asking for a commit in a case like this.
Comment 9 WebKit Review Bot 2012-04-27 15:01:39 PDT
Comment on attachment 139240 [details]
Patch

Clearing flags on attachment: 139240

Committed r115499: <http://trac.webkit.org/changeset/115499>
Comment 10 WebKit Review Bot 2012-04-27 15:01:52 PDT
All reviewed patches have been landed.  Closing bug.