Bug 84942 - MediaStream API: Change LocalMediaStream::stop to be synchronous
Summary: MediaStream API: Change LocalMediaStream::stop to be synchronous
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on:
Blocks: 56459
  Show dependency tree / graph
 
Reported: 2012-04-26 04:02 PDT by Tommy Widenflycht
Modified: 2012-04-30 10:43 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.42 KB, patch)
2012-04-26 04:06 PDT, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Patch (2.91 KB, patch)
2012-04-30 01:39 PDT, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2012-04-26 04:02:33 PDT 
Since I changed LocalMediaStream to be a ActiveDOMObject recently the stop behaviour needs to change since it is no longer a good idea to start a timer when called.
Comment 1 Tommy Widenflycht 2012-04-26 04:06:09 PDT 
Created attachment 138970 [details]
Patch
Comment 2 James Robinson 2012-04-30 01:21:22 PDT 
Comment on attachment 138970 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138970&action=review

> Source/WebCore/Modules/mediastream/LocalMediaStream.cpp:2
> + * Copyright (C) 2012 Google Inc. All rights reserved.

we don't do this in WebKit, just leave the date alone

> Source/WebCore/Modules/mediastream/LocalMediaStream.h:2
> + * Copyright (C) 2012 Google Inc. All rights reserved.

same here
Comment 3 Tommy Widenflycht 2012-04-30 01:39:50 PDT 
Created attachment 139426 [details]
Patch
Comment 4 Tommy Widenflycht 2012-04-30 01:41:16 PDT 
Comment on attachment 138970 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138970&action=review

>> Source/WebCore/Modules/mediastream/LocalMediaStream.cpp:2
>> + * Copyright (C) 2012 Google Inc. All rights reserved.
> 
> we don't do this in WebKit, just leave the date alone

Done.

>> Source/WebCore/Modules/mediastream/LocalMediaStream.h:2
>> + * Copyright (C) 2012 Google Inc. All rights reserved.
> 
> same here

Done.
Comment 5 Adam Bergkvist 2012-04-30 07:18:20 PDT 
This patch changes specified (and testable) API behavior. The "ended" event will be dispatched synchronously when LocalMediaStream.stop() is called from JavaScript.

I don't think calling MediaStreamCenter::didStopLocalMediaStream() from ActiveDOMObject::stop() is the right approach. I've posted a bug to discuss this. See http://webkit.org/b/85191
Comment 6 WebKit Review Bot 2012-04-30 10:43:55 PDT 
Comment on attachment 139426 [details]
Patch

Clearing flags on attachment: 139426

Committed r115649: <http://trac.webkit.org/changeset/115649>
Comment 7 WebKit Review Bot 2012-04-30 10:43:59 PDT 
All reviewed patches have been landed.  Closing bug.