Bug 84926 - [chromium] Remove guarded virtual methods from WebFilterOperation API
Summary: [chromium] Remove guarded virtual methods from WebFilterOperation API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-25 19:07 PDT by Dana Jansens
Modified: 2012-04-26 00:02 PDT (History)
9 users (show)

See Also:


Attachments
Patch (14.84 KB, patch)
2012-04-25 19:12 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff
Patch for landing (14.84 KB, patch)
2012-04-25 21:31 PDT, Dana Jansens
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-04-25 19:07:59 PDT
[chromium] Cannot use guarded virtual methods in public API classes
Comment 1 Dana Jansens 2012-04-25 19:12:50 PDT
Created attachment 138925 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-25 19:14:42 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 James Robinson 2012-04-25 20:46:53 PDT
Comment on attachment 138925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138925&action=review

> Source/Platform/ChangeLog:3
> +        [chromium] Cannot use guarded virtual methods in public API classes

this is not a description of a bug (public API classes shouldn't allow guarded virtual methods, most likely) and it's not a good description of what this patch is changing. can you update it (and the WebCore/ChangeLog entry too)?
Comment 4 Dana Jansens 2012-04-25 21:31:39 PDT
Created attachment 138931 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-04-25 22:43:40 PDT
Comment on attachment 138931 [details]
Patch for landing

Clearing flags on attachment: 138931

Committed r115291: <http://trac.webkit.org/changeset/115291>
Comment 6 WebKit Review Bot 2012-04-25 22:43:45 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Darin Fisher (:fishd, Google) 2012-04-25 23:58:21 PDT
Comment on attachment 138931 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=138931&action=review

> Source/Platform/chromium/public/WebFilterOperation.h:74
> +    enum BasicComponentTransferFilterType {

"BasicComponentTransfer" appears both as part of the struct name as as
a prefix for the enum.  why duplicate the prefix?
Comment 8 Dana Jansens 2012-04-26 00:02:51 PDT
Comment on attachment 138931 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=138931&action=review

>> Source/Platform/chromium/public/WebFilterOperation.h:74
>> +    enum BasicComponentTransferFilterType {
> 
> "BasicComponentTransfer" appears both as part of the struct name as as
> a prefix for the enum.  why duplicate the prefix?

Because it is a sub-FilterType specific to this class. There is a FilterType in the base class that specifies which subclass the operation is. This specifies which FilterType for a BasicComponentTransfer.