[chromium] Cannot use guarded virtual methods in public API classes
Created attachment 138925 [details] Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment on attachment 138925 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138925&action=review > Source/Platform/ChangeLog:3 > + [chromium] Cannot use guarded virtual methods in public API classes this is not a description of a bug (public API classes shouldn't allow guarded virtual methods, most likely) and it's not a good description of what this patch is changing. can you update it (and the WebCore/ChangeLog entry too)?
Created attachment 138931 [details] Patch for landing
Comment on attachment 138931 [details] Patch for landing Clearing flags on attachment: 138931 Committed r115291: <http://trac.webkit.org/changeset/115291>
All reviewed patches have been landed. Closing bug.
Comment on attachment 138931 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=138931&action=review > Source/Platform/chromium/public/WebFilterOperation.h:74 > + enum BasicComponentTransferFilterType { "BasicComponentTransfer" appears both as part of the struct name as as a prefix for the enum. why duplicate the prefix?
Comment on attachment 138931 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=138931&action=review >> Source/Platform/chromium/public/WebFilterOperation.h:74 >> + enum BasicComponentTransferFilterType { > > "BasicComponentTransfer" appears both as part of the struct name as as > a prefix for the enum. why duplicate the prefix? Because it is a sub-FilterType specific to this class. There is a FilterType in the base class that specifies which subclass the operation is. This specifies which FilterType for a BasicComponentTransfer.