webkitpy: fix race in unit tests for manager_worker_broker
Created attachment 138923 [details] Patch
Comment on attachment 138923 [details] Patch Seems not ideal to have a default value that you only want to use in tests. How about leave the timeout value explicit and just passing timeout=None in the calling locations?
(In reply to comment #2) > (From update of attachment 138923 [details]) > Seems not ideal to have a default value that you only want to use in tests. How about leave the timeout value explicit and just passing timeout=None in the calling locations? That's a much better idea, thanks!
cancelling this patch ... after more testing, there's something else weird going on with this hang, and the join(None) by itself doesn't seem to fix it.
Created attachment 139091 [details] Patch
Created attachment 139093 [details] delete stray import
Comment on attachment 139093 [details] delete stray import Attachment 139093 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12556235 New failing tests: fast/images/gif-large-checkerboard.html
Created attachment 139211 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Committed r115452: <http://trac.webkit.org/changeset/115452>