Bug 84916 - Placeholder view is immediately removed from hosting window upon entering full screen.
Summary: Placeholder view is immediately removed from hosting window upon entering ful...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks: 85388
  Show dependency treegraph
 
Reported: 2012-04-25 17:45 PDT by Jer Noble
Modified: 2012-05-03 14:07 PDT (History)
0 users

See Also:


Attachments
Patch (3.39 KB, patch)
2012-04-25 17:48 PDT, Jer Noble
darin: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2012-04-25 17:45:26 PDT
Placeholder view is immediately removed from hosting window upon entering full screen.
Comment 1 Jer Noble 2012-04-25 17:48:46 PDT
Created attachment 138908 [details]
Patch
Comment 2 Darin Adler 2012-04-25 17:54:32 PDT
Comment on attachment 138908 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138908&action=review

> Source/WebKit/mac/WebView/WebFullScreenController.mm:457
> +    [[view superview] addSubview:otherView positioned:NSWindowAbove relativeTo:otherView];r114567

Oops.
Comment 3 Build Bot 2012-04-25 17:56:06 PDT
Comment on attachment 138908 [details]
Patch

Attachment 138908 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12522620
Comment 4 Darin Adler 2012-04-25 17:56:35 PDT
Comment on attachment 138908 [details]
Patch

r=me but please don't check in the typo since its ill break the build!

What about test coverage?
Comment 5 Jer Noble 2012-04-25 19:46:37 PDT
(In reply to comment #4)
> (From update of attachment 138908 [details])
> r=me but please don't check in the typo since its ill break the build!

Whoops. I fixed that in the WebKit2 side of the patch; I'll fix it here too. 

> What about test coverage?

This issue was found by manual testing, and this fix will require manual testing too.
Comment 6 Jer Noble 2012-04-26 09:51:45 PDT
Committed r115324: <http://trac.webkit.org/changeset/115324>