RESOLVED FIXED84899
Add methods to create WebArrayBuffer/WebArrayBufferView from v8 objects 
https://bugs.webkit.org/show_bug.cgi?id=84899
Summary Add methods to create WebArrayBuffer/WebArrayBufferView from v8 objects
Antony Sargent
Reported 2012-04-25 15:47:53 PDT
WebArrayBuffer has a method to convert a WebArrayBuffer into a v8 object, but not to create a WebArrayBuffer given a v8 object.
Attachments
Patch (4.31 KB, patch)
2012-05-02 15:58 PDT, Antony Sargent 		no flags
DetailsFormatted DiffDiff
Patch (4.74 KB, patch)
2012-05-03 08:44 PDT, Antony Sargent 		no flags
DetailsFormatted DiffDiff
Patch (4.35 KB, patch)
2012-05-03 09:08 PDT, Antony Sargent 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antony Sargent
Comment 1 2012-05-02 15:04:19 PDT
This is needed for http://codereview.chromium.org/10161038/, to be able to support binary values for chrome extension API request/response parameters.
Antony Sargent
Comment 2 2012-05-02 15:58:07 PDT
Created attachment 139901 [details] Patch
WebKit Review Bot
Comment 3 2012-05-02 16:01:06 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Kenneth Russell
Comment 4 2012-05-02 16:53:02 PDT
Comment on attachment 139901 [details] Patch This looks good to me based on our offline discussion about use cases. However, one of the WebKit API owners will need to r+ it.
Adam Barth
Comment 5 2012-05-02 21:17:43 PDT
Comment on attachment 139901 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139901&action=review > Source/WebKit/chromium/public/WebArrayBuffer.h:71 > + WEBKIT_EXPORT static WebArrayBuffer* fromV8Value(v8::Handle<v8::Value>); Can we call this function createFromV8Value to make it clear that this function allocates memory? > Source/WebKit/chromium/public/platform/WebArrayBufferView.h:61 > + WEBKIT_EXPORT static WebArrayBufferView* fromV8Value(v8::Handle<v8::Value>); ditto
Antony Sargent
Comment 6 2012-05-03 08:44:56 PDT
Created attachment 140023 [details] Patch
Antony Sargent
Comment 7 2012-05-03 09:01:17 PDT
oops, looks like I accidentally messed up 2 lines in the ChangeLog below my entry - uploading new patch..
Antony Sargent
Comment 8 2012-05-03 09:08:38 PDT
Created attachment 140029 [details] Patch
Adam Barth
Comment 9 2012-05-03 10:51:29 PDT
Thanks@
WebKit Review Bot
Comment 10 2012-05-03 11:57:06 PDT
Comment on attachment 140029 [details] Patch Clearing flags on attachment: 140029 Committed r115995: <http://trac.webkit.org/changeset/115995>
WebKit Review Bot
Comment 11 2012-05-03 11:57:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.