Bug 84898 - Biolab disaster crashes on ToT
Summary: Biolab disaster crashes on ToT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-25 15:46 PDT by Oliver Hunt
Modified: 2012-04-25 16:00 PDT (History)
0 users

See Also:


Attachments
Patch (2.58 KB, patch)
2012-04-25 15:49 PDT, Oliver Hunt
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2012-04-25 15:46:14 PDT
Biolab disaster crashes on ToT
Comment 1 Oliver Hunt 2012-04-25 15:49:31 PDT
Created attachment 138886 [details]
Patch
Comment 2 Filip Pizlo 2012-04-25 15:52:36 PDT
Comment on attachment 138886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138886&action=review

r=me with the simplification

> Source/JavaScriptCore/dfg/DFGVirtualRegisterAllocationPhase.cpp:115
> +            InlineCallFrame& inlineCallFrame = codeBlock()->inlineCallFrames()[i];
> +            CodeBlock* codeBlock = jsCast<FunctionExecutable*>(inlineCallFrame.executable.get())->baselineCodeBlockFor(inlineCallFrame.isCall ? CodeForCall : CodeForConstruct);

baselineCodeBlockForInlineCallFrame(&codeBlock()->inlineCallFrames()[i])
Comment 3 Oliver Hunt 2012-04-25 15:57:15 PDT
Committed r115252: <http://trac.webkit.org/changeset/115252>
Comment 4 Oliver Hunt 2012-04-25 16:00:17 PDT
Committed r115253: <http://trac.webkit.org/changeset/115253>