RESOLVED FIXED 84877
Layout Test fast/css/getPropertyValue-border.html is failing 
https://bugs.webkit.org/show_bug.cgi?id=84877
Summary Layout Test fast/css/getPropertyValue-border.html is failing
Hin-Chung Lam
Reported 2012-04-25 11:16:59 PDT
The following layout test is failing on chromium fast/css/getPropertyValue-border.html Probable cause: Test starts failing since this change: http://trac.webkit.org/changeset/115227 chromium.webkit flakiness bots results: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@ToT - chromium.org&tests=fast/css/getPropertyValue-border.html
Attachments
Patch (1.24 KB, patch)
2012-04-26 06:14 PDT, Marcus Bulach 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-04-25 12:42:19 PDT
I think this was caused by my last-minute change to use StringBuilder. Will land a build fix soon.
Ryosuke Niwa
Comment 2 2012-04-25 14:16:55 PDT
Fixed in http://trac.webkit.org/changeset/115244.
Marcus Bulach
Comment 3 2012-04-26 04:01:39 PDT
this test seems to be happy now: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fcss%2FgetPropertyValue-border.html should we remove it from test_expections.txt?
Ryosuke Niwa
Comment 4 2012-04-26 04:41:21 PDT
Yes.
Marcus Bulach
Comment 5 2012-04-26 06:14:19 PDT
Reopening to attach new patch.
Marcus Bulach
Comment 6 2012-04-26 06:14:22 PDT
Created attachment 138985 [details] Patch
Ryosuke Niwa
Comment 7 2012-04-26 12:10:39 PDT
Comment on attachment 138985 [details] Patch You can make these changes without a review.
WebKit Review Bot
Comment 8 2012-04-26 14:25:32 PDT
Comment on attachment 138985 [details] Patch Rejecting attachment 138985 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #1 FAILED at 3678. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Ryosuke Ni..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12553002
Ryosuke Niwa
Comment 9 2012-04-26 14:44:24 PDT
Comment on attachment 138985 [details] Patch Done in http://trac.webkit.org/changeset/115371.
Note You need to log in before you can comment on or make changes to this bug.