Bug 84864 – [Qt] Printing Page-Layouting broken (height unknown)

• Status: RESOLVED
• Resolution: FIXED
• Component: Printing

[Milian Wolff]

Printing with the Qt port is currently broken, because the page height is not passed to the print context. This results in various issues, most prominently all those page-break-* CSS3 attributes are not handled.

The reason that this was not catched by the existing unit tests, is that no ref/pixel test exists for this. Instead, the current tests use LTC::pageNumberForElementById which eventually calls PrintContext::pageNumberForElement, bypassing QWebFrame::print alltogether.

The fix is trivial, one just needs to replace

    printContext.begin(pageRect.width());

with

    printContext.begin(pageRect.width(), pageRect.height());

in QWebFrame::print. I'll supply a patch for that. But I see no way to write a unit test for that (as that code creates PDFs). Anyhow, lets hope you will merge it anyways.

[Milian Wolff]

Created attachment 138835 [details]
Patch

[WebKit Review Bot]

Comment on attachment 138835 [details]
Patch

Clearing flags on attachment: 138835

Committed r115832: <http://trac.webkit.org/changeset/115832>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.