Bug 84862 - [BlackBerry] Possible JS re-entrancy caused by UI event handler
Summary: [BlackBerry] Possible JS re-entrancy caused by UI event handler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-25 07:41 PDT by Yong Li
Modified: 2012-12-13 15:42 PST (History)
4 users (show)

See Also:


Attachments
the patch (28.42 KB, patch)
2012-04-25 07:42 PDT, Yong Li
no flags Details | Formatted Diff | Diff
fix style (28.45 KB, patch)
2012-04-25 08:04 PDT, Yong Li
no flags Details | Formatted Diff | Diff
a fix for the previous patch (1.88 KB, patch)
2012-04-25 15:05 PDT, Yong Li
no flags Details | Formatted Diff | Diff
a fix (1.25 KB, patch)
2012-12-13 14:54 PST, Yong Li
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yong Li 2012-04-25 07:41:26 PDT
To avoid possible JS re-entrancy caused by UI events when page loading is deferred.
Comment 1 Yong Li 2012-04-25 07:42:44 PDT
Created attachment 138808 [details]
the patch
Comment 2 WebKit Review Bot 2012-04-25 07:46:49 PDT
Attachment 138808 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp',..." exit_code: 1
Source/WebKit/blackberry/Api/WebPage.cpp:3051:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebKit/blackberry/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yong Li 2012-04-25 08:02:13 PDT
Comment on attachment 138808 [details]
the patch

to fix style
Comment 4 Yong Li 2012-04-25 08:04:20 PDT
Created attachment 138811 [details]
fix style
Comment 5 Antonio Gomes 2012-04-25 13:10:14 PDT
Comment on attachment 138811 [details]
fix style

very nice!
Comment 6 WebKit Review Bot 2012-04-25 14:22:12 PDT
Comment on attachment 138811 [details]
fix style

Clearing flags on attachment: 138811

Committed r115245: <http://trac.webkit.org/changeset/115245>
Comment 7 WebKit Review Bot 2012-04-25 14:22:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Yong Li 2012-04-25 15:05:48 PDT
Created attachment 138878 [details]
a fix for the previous patch

when double-checking the patch, I found a bug in the previous patch.
Comment 9 Yong Li 2012-04-25 15:06:55 PDT
reopening
Comment 10 WebKit Review Bot 2012-04-26 06:54:45 PDT
Comment on attachment 138878 [details]
a fix for the previous patch

Clearing flags on attachment: 138878

Committed r115308: <http://trac.webkit.org/changeset/115308>
Comment 11 WebKit Review Bot 2012-04-26 06:54:50 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Yong Li 2012-12-13 14:47:37 PST
reopen to fix a one-character bug in the patch
Comment 13 Yong Li 2012-12-13 14:54:01 PST
Created attachment 179346 [details]
a fix
Comment 14 Rob Buis 2012-12-13 14:56:11 PST
Comment on attachment 179346 [details]
a fix

Obvious fix, obvious r+ :)
Comment 15 WebKit Review Bot 2012-12-13 15:42:33 PST
Comment on attachment 179346 [details]
a fix

Clearing flags on attachment: 179346

Committed r137671: <http://trac.webkit.org/changeset/137671>
Comment 16 WebKit Review Bot 2012-12-13 15:42:37 PST
All reviewed patches have been landed.  Closing bug.