Bug 84849 - Web Inspector: use composite node provider for diff nodes in heap profiler
Summary: Web Inspector: use composite node provider for diff nodes in heap profiler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-25 05:17 PDT by Yury Semikhatsky
Modified: 2012-04-25 05:31 PDT (History)
11 users (show)

See Also:


Attachments
Patch (23.39 KB, patch)
2012-04-25 05:24 PDT, Yury Semikhatsky
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-04-25 05:17:32 PDT
Instead of overriding HeapSnapshotGridNode.prototype.populateChildren in HeapSnapshotDiffNode we should use a composite nodes provider which will populate first added nodes and after that deleted ones. This step is necessary for adding "reveal element in heap profile" action.
Comment 1 Yury Semikhatsky 2012-04-25 05:24:39 PDT
Created attachment 138788 [details]
Patch
Comment 2 Pavel Feldman 2012-04-25 05:26:51 PDT
Comment on attachment 138788 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138788&action=review

> Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:711
> +    serializeNextItems: function(count, callback)

serializeSubsequentItems.

> Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:713
> +        function didReceiveAllItems(items) {

{ on the next line.
Comment 3 Yury Semikhatsky 2012-04-25 05:29:40 PDT
(In reply to comment #2)
> (From update of attachment 138788 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=138788&action=review
> 
> > Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:711
> > +    serializeNextItems: function(count, callback)
> 
> serializeSubsequentItems.
> 
Done.

> > Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:713
> > +        function didReceiveAllItems(items) {
> 
> { on the next line.
Done.
Comment 4 Yury Semikhatsky 2012-04-25 05:31:20 PDT
Committed r115189: <http://trac.webkit.org/changeset/115189>