Instead of overriding HeapSnapshotGridNode.prototype.populateChildren in HeapSnapshotDiffNode we should use a composite nodes provider which will populate first added nodes and after that deleted ones. This step is necessary for adding "reveal element in heap profile" action.
Created attachment 138788 [details] Patch
Comment on attachment 138788 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138788&action=review > Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:711 > + serializeNextItems: function(count, callback) serializeSubsequentItems. > Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:713 > + function didReceiveAllItems(items) { { on the next line.
(In reply to comment #2) > (From update of attachment 138788 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=138788&action=review > > > Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:711 > > + serializeNextItems: function(count, callback) > > serializeSubsequentItems. > Done. > > Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:713 > > + function didReceiveAllItems(items) { > > { on the next line. Done.
Committed r115189: <http://trac.webkit.org/changeset/115189>