RESOLVED FIXED Bug 84849
Web Inspector: use composite node provider for diff nodes in heap profiler 
https://bugs.webkit.org/show_bug.cgi?id=84849
Summary Web Inspector: use composite node provider for diff nodes in heap profiler
Yury Semikhatsky
Reported 2012-04-25 05:17:32 PDT
Instead of overriding HeapSnapshotGridNode.prototype.populateChildren in HeapSnapshotDiffNode we should use a composite nodes provider which will populate first added nodes and after that deleted ones. This step is necessary for adding "reveal element in heap profile" action.
Attachments
Patch (23.39 KB, patch)
2012-04-25 05:24 PDT, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-04-25 05:24:39 PDT
Created attachment 138788 [details] Patch
Pavel Feldman
Comment 2 2012-04-25 05:26:51 PDT
Comment on attachment 138788 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138788&action=review > Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:711 > + serializeNextItems: function(count, callback) serializeSubsequentItems. > Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:713 > + function didReceiveAllItems(items) { { on the next line.
Yury Semikhatsky
Comment 3 2012-04-25 05:29:40 PDT
(In reply to comment #2) > (From update of attachment 138788 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=138788&action=review > > > Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:711 > > + serializeNextItems: function(count, callback) > > serializeSubsequentItems. > Done. > > Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:713 > > + function didReceiveAllItems(items) { > > { on the next line. Done.
Yury Semikhatsky
Comment 4 2012-04-25 05:31:20 PDT
Committed r115189: <http://trac.webkit.org/changeset/115189>
Note You need to log in before you can comment on or make changes to this bug.