Bug 84830 - [EFL] Enable VIDEO_TRACK feature
Summary: [EFL] Enable VIDEO_TRACK feature
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-25 02:05 PDT by Chris Dumez
Modified: 2012-05-06 22:53 PDT (History)
4 users (show)

See Also:


Attachments
Patch (15.43 KB, patch)
2012-04-25 03:52 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (15.59 KB, patch)
2012-04-25 03:56 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (15.93 KB, patch)
2012-04-25 04:27 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (15.80 KB, patch)
2012-04-25 23:07 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (15.83 KB, patch)
2012-04-25 23:51 PDT, Chris Dumez
gustavo: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Proposed patch (15.97 KB, patch)
2012-04-26 10:12 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-04-25 02:05:07 PDT
The VIDEO_TRACK feature enables track support for HTML5 video. It is currently disabled on EFL port but enabled on GTK and MAC ports.
Comment 1 Chris Dumez 2012-04-25 03:52:24 PDT
Created attachment 138776 [details]
Patch
Comment 2 Chris Dumez 2012-04-25 03:56:07 PDT
Created attachment 138777 [details]
Patch

Rebase on master so that it applies cleanly.
Comment 3 Chris Dumez 2012-04-25 04:27:03 PDT
Created attachment 138784 [details]
Patch

Update patch to fix compilation when VIDEO_TRACK is disabled.
Comment 4 Gyuyoung Kim 2012-04-25 17:02:12 PDT
Comment on attachment 138784 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138784&action=review

> Source/WebKit/efl/ewk/ewk_view.cpp:724
> +    priv->settings.shouldDisplaySubtitles = priv->pageSettings->shouldDisplaySubtitles();

I think it is better to add this settings by alphabetic sorting. So, is it better to move below 729 line.

> Source/WebKit/efl/ewk/ewk_view.cpp:4084
> +    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, EINA_FALSE);

Use standard boolean type instead of EINA_FALSE.

> Source/WebKit/efl/ewk/ewk_view.cpp:4085
> +    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, EINA_FALSE);

ditto.

> Source/WebKit/efl/ewk/ewk_view.cpp:4108
> +    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, EINA_FALSE);

ditto.

> Source/WebKit/efl/ewk/ewk_view.cpp:4109
> +    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, EINA_FALSE);

ditto.

> Source/WebKit/efl/ewk/ewk_view.cpp:4132
> +    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, EINA_FALSE);

ditto.

> Source/WebKit/efl/ewk/ewk_view.cpp:4133
> +    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, EINA_FALSE);

ditto.

> Source/WebKit/efl/ewk/ewk_view.h:2460
> +EAPI void ewk_view_setting_should_display_subtitles_set(const Evas_Object *o, Eina_Bool enable);

We don't use const keyword in _set APIs.

> Source/WebKit/efl/ewk/ewk_view.h:2481
> +EAPI void ewk_view_setting_should_display_captions_set(const Evas_Object *o, Eina_Bool enable);

ditto.

> Source/WebKit/efl/ewk/ewk_view.h:2502
> +EAPI void ewk_view_setting_should_display_text_descriptions_set(const Evas_Object *o, Eina_Bool enable);

ditto.

> Tools/ChangeLog:10
> +        * Scripts/build-webkit:

Missing description.
Comment 5 Chris Dumez 2012-04-25 23:07:21 PDT
Created attachment 138938 [details]
Patch

Patch taking feedback into consideration.
Comment 6 Chris Dumez 2012-04-25 23:51:49 PDT
Created attachment 138943 [details]
Patch

Minor changelog fix.
Comment 7 Gyuyoung Kim 2012-04-26 00:16:47 PDT
Comment on attachment 138943 [details]
Patch

Looks fine.
Comment 8 WebKit Review Bot 2012-04-26 09:39:05 PDT
Comment on attachment 138943 [details]
Patch

Rejecting attachment 138943 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/12523914
Comment 9 Chris Dumez 2012-04-26 10:12:40 PDT
Created attachment 139018 [details]
Proposed patch

Fix patch for landing.
Comment 10 WebKit Review Bot 2012-04-26 12:47:48 PDT
Comment on attachment 139018 [details]
Proposed patch

Clearing flags on attachment: 139018

Committed r115341: <http://trac.webkit.org/changeset/115341>
Comment 11 WebKit Review Bot 2012-04-26 12:47:53 PDT
All reviewed patches have been landed.  Closing bug.