Bug 84829 - Failed to render again in offline mode
Summary: Failed to render again in offline mode
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-25 00:22 PDT by Xingnan Wang
Modified: 2014-02-05 10:53 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.37 KB, patch)
2012-04-25 00:24 PDT, Xingnan Wang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xingnan Wang 2012-04-25 00:22:39 PDT 
startRendering() will fail to run when called again.
The background is that, 
I wrote two test cases in offline mode(they shared the same audio context), the one after another finished one failed to run startRendering().

OfflineAudioDestinationNode should reset the flag of m_startedRendering after finishing rendering.
Comment 1 Xingnan Wang 2012-04-25 00:24:22 PDT 
Created attachment 138748 [details]
Patch
Comment 2 Chris Rogers 2012-04-25 11:44:14 PDT 
Hi Xingnan, it's not intended for an OfflineAudioContext to be able to start rendering more than once.  It goes through distinct stages during its life, finally calling back the JS completion function.  You can always create a 2nd or 3rd OfflineAudioContext if you need to do more work, but the original one can't be re-used.  The OfflineAudioContext is not yet in the spec, but I will add it there soon, describing this.
Comment 3 Anders Carlsson 2014-02-05 10:53:07 PST 
Comment on attachment 138748 [details]
Patch

Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.