Bug 84824 - SVG inline style of 'marker-*' does not override
Summary: SVG inline style of 'marker-*' does not override
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-24 21:03 PDT by Dirk Schulze
Modified: 2012-04-27 08:41 PDT (History)
5 users (show)

See Also:


Attachments
Marker with inline style (585 bytes, image/svg+xml)
2012-04-24 21:03 PDT, Dirk Schulze
no flags Details
Patch (10.93 KB, patch)
2012-04-26 16:04 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (10.72 KB, patch)
2012-04-26 16:22 PDT, Rob Buis
zimmermann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2012-04-24 21:03:46 PDT
Created attachment 138732 [details]
Marker with inline style

Inline style should override all other styles. This is not the case for all 'marker' properties. You shouldn't see any red on the attached file.
Comment 1 Rob Buis 2012-04-26 16:04:49 PDT
Created attachment 139089 [details]
Patch
Comment 2 Rob Buis 2012-04-26 16:22:37 PDT
Created attachment 139092 [details]
Patch
Comment 3 Nikolas Zimmermann 2012-04-27 02:00:00 PDT
Comment on attachment 139092 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139092&action=review

Looks great, r=me. Please fix following before landing:

> LayoutTests/svg/custom/inline-style-overrides-markers.svg:20
> +  <line x1="100" y1="100" x2="100" y2="100" style="marker-start: none;marker-mid: none;marker-end: none;" />

I'd propose to draw the (stroked) line, even though no markers are visible. And empty expected.svg looks weird :-)
Comment 4 Rob Buis 2012-04-27 08:41:52 PDT
Landed in r115432.