Bug 84823 – [chromium] Make DRT work without the --test-shell flag in new-run-webkit-tests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dirk Pranke]

[chromium] Make DRT work without the --test-shell flag

[Dirk Pranke]

Created attachment 138726 [details]
work-in-progress roll-up patch

[Eric Seidel (no email)]

Comment on attachment 138726 [details]
work-in-progress roll-up patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138726&action=review

> Tools/Scripts/webkitpy/layout_tests/port/chromium.py:402
> +        self._test_shell = '--test-shell' in port.get_option('additional_drt_flag')

I'm not sure I understand this part.

[Dirk Pranke]

(In reply to comment #2)
> (From update of attachment 138726 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=138726&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/port/chromium.py:402
> > +        self._test_shell = '--test-shell' in port.get_option('additional_drt_flag')
> 
> I'm not sure I understand this part.

This is how we toggle between --test-shell mode and not in the chromium.py code, rather than adding yet another obscure command line flag to NRWT itself.

Eventually this code will go away and we won't support --test-shell mode at all, but this is here now for testing. It's not suitable to land as-is, though, since I'm fairly certain it would break chromium win completely, and may not work on linux either (will know more today).

[Dirk Pranke]

It looks like this more-or-less works on mac and linux, so I'm going to start carving this up into reviewable patches. Win is probably going to take some more work, so I'm planning to make this on by default on Mac and Linux and off by default on Win.

[Dirk Pranke]

This is now on everywhere. Closing.