We should reduce the number of iterations so that it completes.
Created attachment 138723 [details] Patch
Comment on attachment 138723 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138723&action=review > LayoutTests/fast/js/script-tests/random-array-gc-stress.js:-12 > -function gc() > -{ > - if (this.GCController) > - GCController.collect(); > - else > - for (var i = 0; i < 10000; ++i) // Allocate a sufficient number of objects to force a GC. > - ({}); > -} Why are you removing this? Change log does not say.
Created attachment 138724 [details] Patch
Comment on attachment 138724 [details] Patch Seems like this will fail to run due to no gc() function.
Comment on attachment 138724 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138724&action=review > LayoutTests/ChangeLog:10 > + * fast/js/script-tests/random-array-gc-stress.js: Reduce number of iterations so > + that the test can complete without timing out. Also remove the gc() function because > + a gc() function is already provided in resources/js-test-pre.js. Geoff, here’s the explanation of why it’s good to remove the gc function.
Comment on attachment 138724 [details] Patch Clearing flags on attachment: 138724 Committed r115208: <http://trac.webkit.org/changeset/115208>
All reviewed patches have been landed. Closing bug.
Apparently the bots are too slow even for the new version, which passes locally on my machine. Will try to reduce the number of iterations even further.
Created attachment 138897 [details] Patch
Comment on attachment 138897 [details] Patch r=me
Comment on attachment 138897 [details] Patch Clearing flags on attachment: 138897 Committed r115287: <http://trac.webkit.org/changeset/115287>
Still timing out on some bots.
Created attachment 139243 [details] Patch
Comment on attachment 139243 [details] Patch OK. I am increasingly unhappy with this test if it takes so long to run.
Comment on attachment 139243 [details] Patch Clearing flags on attachment: 139243 Committed r115658: <http://trac.webkit.org/changeset/115658>