The added user style sheets from the previous testcases are not cleared for the next one => have flaky results. For example in bug84718 this issue causes flakiness of userscripts/user-style-top-frame-only.html.
Created attachment 138681 [details] Clear added user style sheets before a new testcase execution The patch is unskipping userscripts/user-script-top-frame-only.html so it may be applied after the fix for bug84718 is in place.
Comment on attachment 138681 [details] Clear added user style sheets before a new testcase execution View in context: https://bugs.webkit.org/attachment.cgi?id=138681&action=review > LayoutTests/ChangeLog:6 > + Unskip userscripts/user-style-top-frame-only.html Generally, patch description is placed below "Reviewed by NOBODY (OOPS!)."
Created attachment 138759 [details] Clear added user style sheets before a new testcase execution
(In reply to comment #2) > (From update of attachment 138681 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=138681&action=review > > > LayoutTests/ChangeLog:6 > > + Unskip userscripts/user-style-top-frame-only.html > > Generally, patch description is placed below "Reviewed by NOBODY (OOPS!)." Thanks for review! Changelog is fixed here: https://bugs.webkit.org/attachment.cgi?id=138759
Comment on attachment 138759 [details] Clear added user style sheets before a new testcase execution Looks good, thanks.
Comment on attachment 138759 [details] Clear added user style sheets before a new testcase execution OK, looks right to me.
Comment on attachment 138759 [details] Clear added user style sheets before a new testcase execution Rejecting attachment 138759 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: jects to file Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h.rej patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp Hunk #1 FAILED at 213. 1 out of 1 hunk FAILED -- saving rejects to file Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Gustavo No..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12656672
Needs to rebase.
Created attachment 141103 [details] to be landed.
Comment on attachment 141103 [details] to be landed. Clearing flags on attachment: 141103 Committed r116625: <http://trac.webkit.org/changeset/116625>
All reviewed patches have been landed. Closing bug.