Bug 84782 - Improve code for embedding flakiness dashboard as an iframe
Summary: Improve code for embedding flakiness dashboard as an iframe
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-24 14:34 PDT by Ojan Vafai
Modified: 2012-04-24 16:43 PDT (History)
3 users (show)

See Also:


Attachments
Patch (7.57 KB, patch)
2012-04-24 14:37 PDT, Ojan Vafai
dpranke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-04-24 14:34:40 PDT
Improve code for embedding flakiness dashboard as an iframe
Comment 1 Ojan Vafai 2012-04-24 14:37:23 PDT
Created attachment 138649 [details]
Patch
Comment 2 Dirk Pranke 2012-04-24 15:18:53 PDT
Comment on attachment 138649 [details]
Patch

looks reasonable, but who embeds the flakiness dashboard (i.e., why do we want this?). Also, what's a qunit?
Comment 3 Ojan Vafai 2012-04-24 15:44:25 PDT
(In reply to comment #2)
> (From update of attachment 138649 [details])
> looks reasonable, but who embeds the flakiness dashboard (i.e., why do we want this?). Also, what's a qunit?

I have a patch for garden-o-matic to embed it as an iframe. This is so we can see the flakiness details for a test we're viewing.

qunit is the unittesting frameworks that garden-o-matic uses.
Comment 4 Ojan Vafai 2012-04-24 16:43:27 PDT
Committed r115133: <http://trac.webkit.org/changeset/115133>