Bug 84749 - [Coverity] Uninitialized fields in RenderSVGShape constructors
Summary: [Coverity] Uninitialized fields in RenderSVGShape constructors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P4 Normal
Assignee: Florin Malita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-24 12:22 PDT by Florin Malita
Modified: 2012-04-25 06:44 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.04 KB, patch)
2012-04-24 12:40 PDT, Florin Malita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Florin Malita 2012-04-24 12:22:50 PDT
RenderSVGShape::RenderSVGShape(SVGStyledTransformableElement* node):
  * m_strokeContainsFallBack

RenderSVGShape::RenderSVGShape(SVGStyledTransformableElement* node, Path* path, bool isFillFallback):
  * m_needsTransformUpdate
  * m_needsShapeUpdate
  * m_strokeContainsFallBack
  * m_needsBoundariesUpdate

Looks like neither m_strokeContainsFallBack nor the second constructor is being used, so we can simply get rid of them.
Comment 1 Florin Malita 2012-04-24 12:40:26 PDT
Created attachment 138622 [details]
Patch
Comment 2 Darin Adler 2012-04-24 12:42:05 PDT
Comment on attachment 138622 [details]
Patch

Looks fine. Great to remove unused code!
Comment 3 WebKit Review Bot 2012-04-25 06:44:32 PDT
Comment on attachment 138622 [details]
Patch

Clearing flags on attachment: 138622

Committed r115196: <http://trac.webkit.org/changeset/115196>
Comment 4 WebKit Review Bot 2012-04-25 06:44:37 PDT
All reviewed patches have been landed.  Closing bug.