RESOLVED FIXED 84745
Make make-css-file-arrays.pl take js file 
https://bugs.webkit.org/show_bug.cgi?id=84745
Summary Make make-css-file-arrays.pl take js file
Crystal Zhang
Reported 2012-04-24 11:50:07 PDT
Currently make-css-file-arrays.pl now only take css files, we should let it also take js files, because html popups also needs load js files.
Attachments
patch (1.73 KB, patch)
2012-04-24 11:50 PDT, Crystal Zhang 		no flags
DetailsFormatted DiffDiff
updated patch (1.78 KB, patch)
2012-04-24 12:14 PDT, Crystal Zhang 		darin: review-
darin: commit-queue-
DetailsFormatted DiffDiff
patch (2.48 KB, patch)
2012-04-24 12:54 PDT, Crystal Zhang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Crystal Zhang
Comment 1 2012-04-24 11:50:51 PDT
Created attachment 138614 [details] patch
Crystal Zhang
Comment 2 2012-04-24 12:14:20 PDT
Created attachment 138616 [details] updated patch Add bug number.
Darin Adler
Comment 3 2012-04-24 12:16:51 PDT
Comment on attachment 138616 [details] updated patch Change looks OK. WebKit changes need to include a change log entry. The change log entry can explain why this change is needed/good.
Crystal Zhang
Comment 4 2012-04-24 12:54:20 PDT
Created attachment 138625 [details] patch Add ChangeLog.
WebKit Review Bot
Comment 5 2012-04-25 08:28:54 PDT
Comment on attachment 138625 [details] patch Clearing flags on attachment: 138625 Committed r115212: <http://trac.webkit.org/changeset/115212>
WebKit Review Bot
Comment 6 2012-04-25 08:28:59 PDT
All reviewed patches have been landed. Closing bug.
Kent Tamura
Comment 7 2012-04-25 17:44:20 PDT
Comment on attachment 138625 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=138625&action=review make-css-file-arrays.pl is in WebCore/css. I feel it's a little inappropriate to handle JavaScript files. So I made WebCore/make-file-arrays.py. > Source/WebCore/ChangeLog:2 > + https://bugs.webkit.org/show_bug.cgi?id=84875 The bug URL is wrong. This is 84745.
Antonio Gomes
Comment 8 2012-04-25 20:27:44 PDT
(In reply to comment #7) > (From update of attachment 138625 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=138625&action=review > > make-css-file-arrays.pl is in WebCore/css. I feel it's a little inappropriate to handle JavaScript files. So I made WebCore/make-file-arrays.py. I think you are right. Crystal?
Crystal Zhang
Comment 9 2012-04-26 08:20:23 PDT
(In reply to comment #8) > (In reply to comment #7) > > (From update of attachment 138625 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=138625&action=review > > > > make-css-file-arrays.pl is in WebCore/css. I feel it's a little inappropriate to handle JavaScript files. So I made WebCore/make-file-arrays.py. > > I think you are right. Crystal? WebCore/make-file-arrays.py is quite new, I didn't notice that. Yeah, I think Kent is right. Should I revert the commit?
Antonio Gomes
Comment 10 2012-04-26 08:47:30 PDT
We can reopen this bug, and fix it properly (not necessarily revert, unless kent feels strong about it)
Note You need to log in before you can comment on or make changes to this bug.