Bug 84744 - [BlackBerry] Perform spellcheck before handling TouchRelease event
Summary: [BlackBerry] Perform spellcheck before handling TouchRelease event
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nima Ghanavatian
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-24 11:33 PDT by Nima Ghanavatian
Modified: 2012-04-24 18:02 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.02 KB, patch)
2012-04-24 11:41 PDT, Nima Ghanavatian 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nima Ghanavatian 2012-04-24 11:33:51 PDT 
After rebasing to master_35, it appears as though some code has been moved around.
Here, we were handling the TouchReleased event before calling spellcheck.  This
meant that when we finally got the call to spellcheck, the fatFinger result had been
reset and the spelling markers had been removed.
    
In addition, based on https://bugs.webkit.org/show_bug.cgi?id=66330
I am also updating the BlackBerry specific documentMarkerContainingPoint to use
LayoutPoint instead of IntPoint.
Comment 1 Nima Ghanavatian 2012-04-24 11:41:49 PDT 
Created attachment 138613 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-24 18:02:03 PDT 
Comment on attachment 138613 [details]
Patch

Clearing flags on attachment: 138613

Committed r115152: <http://trac.webkit.org/changeset/115152>
Comment 3 WebKit Review Bot 2012-04-24 18:02:07 PDT 
All reviewed patches have been landed.  Closing bug.