Bug 84727 - [4] Fix build when ENABLE_JIT_CONSTANT_BLINDING enabled
Summary: [4] Fix build when ENABLE_JIT_CONSTANT_BLINDING enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-24 07:55 PDT by thouraya
Modified: 2012-04-24 17:13 PDT (History)
2 users (show)

See Also:


Attachments
fix build issue when ENABLE_JIT_CONSTANT_BLINDING enabled (3.72 KB, patch)
2012-04-24 08:24 PDT, thouraya
no flags Details | Formatted Diff | Diff
fix build issue when ENABLE_JIT_CONSTANT_BLINDING enabled (3.72 KB, patch)
2012-04-24 08:34 PDT, thouraya
no flags Details | Formatted Diff | Diff
fix build issue when ENABLE_JIT_CONSTANT_BLINDING enabled (3.68 KB, patch)
2012-04-24 08:45 PDT, thouraya
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description thouraya 2012-04-24 07:55:16 PDT
Building Webkit for Gtk platform(ENABLE_JIT_CONSTANT_BLINDING is enabled),  got some undefined functions.
Comment 1 thouraya 2012-04-24 08:24:42 PDT
Created attachment 138565 [details]
fix build issue when ENABLE_JIT_CONSTANT_BLINDING enabled
Comment 2 WebKit Review Bot 2012-04-24 08:28:45 PDT
Attachment 138565 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:161:  Missing space before ( in if(  [whitespace/parens] [5]
Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:209:  Missing space before ( in if(  [whitespace/parens] [5]
Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:211:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 thouraya 2012-04-24 08:34:43 PDT
Created attachment 138569 [details]
fix build issue when ENABLE_JIT_CONSTANT_BLINDING enabled
Comment 4 WebKit Review Bot 2012-04-24 08:37:53 PDT
Attachment 138569 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:211:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 thouraya 2012-04-24 08:45:51 PDT
Created attachment 138572 [details]
fix build issue when ENABLE_JIT_CONSTANT_BLINDING enabled
Comment 6 WebKit Review Bot 2012-04-24 17:12:47 PDT
Comment on attachment 138572 [details]
fix build issue when ENABLE_JIT_CONSTANT_BLINDING enabled

Clearing flags on attachment: 138572

Committed r115144: <http://trac.webkit.org/changeset/115144>
Comment 7 WebKit Review Bot 2012-04-24 17:13:05 PDT
All reviewed patches have been landed.  Closing bug.