Bug 84715 - [chromium] Don't keep pointers to released layer tree
Summary: [chromium] Don't keep pointers to released layer tree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sami Kyostila
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-24 06:00 PDT by Sami Kyostila
Modified: 2012-04-24 10:44 PDT (History)
5 users (show)

See Also:


Attachments
Patch (7.39 KB, patch)
2012-04-24 06:06 PDT, Sami Kyostila
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sami Kyostila 2012-04-24 06:00:58 PDT
[chromium] Don't keep pointers to released layer tree
Comment 1 Sami Kyostila 2012-04-24 06:06:15 PDT
Created attachment 138546 [details]
Patch
Comment 2 Iain Merrick 2012-04-24 06:19:10 PDT
Looks good, nice catch.

One small comment: is there a named constant you could use instead of -1?
Comment 3 Sami Kyostila 2012-04-24 06:25:26 PDT
Thanks for the review.

> One small comment: is there a named constant you could use instead of -1?

I wondered about the same and found out that -1 seems to be generally used as the "null" layer id in the Chromium compositor code. I guess it would be worth replacing those with a named constant, but I did not want to go there with this particular crash fix.
Comment 4 Adrienne Walker 2012-04-24 09:41:42 PDT
Comment on attachment 138546 [details]
Patch

If this wasn't a crash fix, I'd say you should fix the -1 in this patch, but I'd like to get this fixed sooner rather than later. Can you file a bug for changing -1 to a constant and assign it to yourself?
Comment 5 Nat Duca 2012-04-24 09:45:50 PDT
Comment on attachment 138546 [details]
Patch

Argh, bit by the releaseRootLayer feature AGAIN!
Comment 6 Sami Kyostila 2012-04-24 09:57:22 PDT
(In reply to comment #4)
> (From update of attachment 138546 [details])
> If this wasn't a crash fix, I'd say you should fix the -1 in this patch, but I'd like to get this fixed sooner rather than later. Can you file a bug for changing -1 to a constant and assign it to yourself?

Sure, done: https://bugs.webkit.org/show_bug.cgi?id=84737
Comment 7 Sami Kyostila 2012-04-24 10:09:40 PDT
(In reply to comment #5)
> Argh, bit by the releaseRootLayer feature AGAIN!

It's a treacherous thing :( I think this particular bug would have been caught by running webkit_unit_tests with Valgrind -- any reason why we're not doing that?
Comment 8 WebKit Review Bot 2012-04-24 10:44:15 PDT
Comment on attachment 138546 [details]
Patch

Clearing flags on attachment: 138546

Committed r115080: <http://trac.webkit.org/changeset/115080>
Comment 9 WebKit Review Bot 2012-04-24 10:44:27 PDT
All reviewed patches have been landed.  Closing bug.