Bug 84709 - [EFL][DRT] Reset DRT settings to their default values after a testcase was executed.
Summary: [EFL][DRT] Reset DRT settings to their default values after a testcase was ex...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-24 05:11 PDT by Mikhail Pozdnyakov
Modified: 2012-05-22 11:11 PDT (History)
10 users (show)

See Also:

Attachments
reset some missed DRT settings (2.95 KB, patch)
2012-04-24 05:26 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
reset some missed DRT settings (3.12 KB, patch)
2012-04-24 05:46 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-04-24 05:11:52 PDT 
Not all the settings affected by layout testcases are reset in DumpRenderTreeChrome::resetDefaultsToConsistentValues().
ones corresponding to the setters below are missed:
    ewk_view_setting_user_stylesheet_set
    ewk_view_setting_enable_xss_auditor_set
    ewk_view_setting_enable_developer_extras_set
    ewk_view_setting_minimum_timer_interval_set
    DumpRenderTreeSupportEfl::setSmartInsertDeleteEnabled
    DumpRenderTreeSupportEfl::setSelectTrailingWhitespaceEnabled
    DumpRenderTreeSupportEfl::setDefersLoading
    DumpRenderTreeSupportEfl::setEditingBehavior

It may cause flakiness of the test results.
Comment 1 Mikhail Pozdnyakov 2012-04-24 05:26:36 PDT 
Created attachment 138541 [details]
reset some missed DRT settings
Comment 2 Dominik Röttsches (drott) 2012-04-24 05:37:11 PDT 
Comment on attachment 138541 [details]
reset some missed DRT settings

View in context: https://bugs.webkit.org/attachment.cgi?id=138541&action=review

Otherwise LGTM.

> Tools/ChangeLog:7
> +

I think it makes sense to put the explanation from the bug report here, e.g.:

"Not all the settings that can be changed by layout testcases through a JS API were reset in DumpRenderTreeChrome::resetDefaultsToConsistentValues()."
Comment 3 Mikhail Pozdnyakov 2012-04-24 05:46:01 PDT 
Created attachment 138544 [details]
reset some missed DRT settings
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-04-24 16:00:57 PDT 
Comment on attachment 138544 [details]
reset some missed DRT settings

Makes sense.
Comment 5 Gyuyoung Kim 2012-04-24 19:54:34 PDT 
Comment on attachment 138544 [details]
reset some missed DRT settings

Looks fine.
Comment 6 Eric Seidel (no email) 2012-04-25 00:31:07 PDT 
Comment on attachment 138544 [details]
reset some missed DRT settings

OK.
Comment 7 WebKit Review Bot 2012-04-25 00:38:35 PDT 
Comment on attachment 138544 [details]
reset some missed DRT settings

Clearing flags on attachment: 138544

Committed r115173: <http://trac.webkit.org/changeset/115173>
Comment 8 WebKit Review Bot 2012-04-25 00:38:40 PDT 
All reviewed patches have been landed.  Closing bug.