Not all the settings affected by layout testcases are reset in DumpRenderTreeChrome::resetDefaultsToConsistentValues(). ones corresponding to the setters below are missed: ewk_view_setting_user_stylesheet_set ewk_view_setting_enable_xss_auditor_set ewk_view_setting_enable_developer_extras_set ewk_view_setting_minimum_timer_interval_set DumpRenderTreeSupportEfl::setSmartInsertDeleteEnabled DumpRenderTreeSupportEfl::setSelectTrailingWhitespaceEnabled DumpRenderTreeSupportEfl::setDefersLoading DumpRenderTreeSupportEfl::setEditingBehavior It may cause flakiness of the test results.
Created attachment 138541 [details] reset some missed DRT settings
Comment on attachment 138541 [details] reset some missed DRT settings View in context: https://bugs.webkit.org/attachment.cgi?id=138541&action=review Otherwise LGTM. > Tools/ChangeLog:7 > + I think it makes sense to put the explanation from the bug report here, e.g.: "Not all the settings that can be changed by layout testcases through a JS API were reset in DumpRenderTreeChrome::resetDefaultsToConsistentValues()."
Created attachment 138544 [details] reset some missed DRT settings
Comment on attachment 138544 [details] reset some missed DRT settings Makes sense.
Comment on attachment 138544 [details] reset some missed DRT settings Looks fine.
Comment on attachment 138544 [details] reset some missed DRT settings OK.
Comment on attachment 138544 [details] reset some missed DRT settings Clearing flags on attachment: 138544 Committed r115173: <http://trac.webkit.org/changeset/115173>
All reviewed patches have been landed. Closing bug.