Bug 84705 - [EFL] Enable Web Timing
Summary: [EFL] Enable Web Timing
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Depends on:
Blocks: 30685
  Show dependency treegraph
Reported: 2012-04-24 04:05 PDT by Chris Dumez
Modified: 2012-05-06 22:53 PDT (History)
5 users (show)

See Also:

Patch (3.81 KB, patch)
2012-04-24 04:15 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-04-24 04:05:15 PDT
Web Timing should be enabled for the EFL port.
Comment 1 Chris Dumez 2012-04-24 04:15:30 PDT
Created attachment 138533 [details]
Comment 2 Tony Gentilcore 2012-04-24 04:34:27 PDT
Comment on attachment 138533 [details]

In order for navigation timing to completely work, each port needs to provide some detailed network times via the platform/network/ResourceLoadTiming.h API. Without it, some parts of the API won't be correct.

I'm happy to give an r+ either way, but just wanted to make sure that was already hooked up or else it is understood that some information won't be correct.
Comment 3 Chris Dumez 2012-04-24 04:39:17 PDT
I believe that work was already done in Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp as part of enabling Web Timing for GTK port. The EFL port is using libsoup as well. Am I missing something?
Comment 4 Chris Dumez 2012-04-24 04:40:26 PDT
I'm referring to this patch:
Comment 5 Tony Gentilcore 2012-04-24 05:11:19 PDT
Comment on attachment 138533 [details]

Thanks for confirming. I just wasn't aware that libsoup was used by EFL.

Excited to see this turned on.
Comment 6 WebKit Review Bot 2012-04-24 06:48:43 PDT
Comment on attachment 138533 [details]

Clearing flags on attachment: 138533

Committed r115046: <http://trac.webkit.org/changeset/115046>
Comment 7 WebKit Review Bot 2012-04-24 06:48:48 PDT
All reviewed patches have been landed.  Closing bug.