Bug 84667 - Implement the field cache of ObjcClass in WebKit types
: Implement the field cache of ObjcClass in WebKit types
Status: RESOLVED FIXED
: WebKit
WebCore Misc.
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2012-04-23 19:11 PST by
Modified: 2012-04-24 10:05 PST (History)


Attachments
Patch (5.89 KB, patch)
2012-04-23 19:18 PST, Benjamin Poulain
no flags Review Patch | Details | Formatted Diff | Diff
Patch for landing (5.87 KB, patch)
2012-04-24 00:00 PST, Benjamin Poulain
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-04-23 19:11:20 PST
When manipulating bridged object, we spend a lot of time in ObjcClass::fieldNamed().
------- Comment #1 From 2012-04-23 19:18:47 PST -------
Created an attachment (id=138487) [details]
Patch
------- Comment #2 From 2012-04-23 19:20:08 PST -------
The main gain is from not allocating any memory in that case. Not having to call a function is a bonus :)

I have not modified ObjcClass::methodsNamed() due to a bug I will fix separately.
------- Comment #3 From 2012-04-23 19:42:32 PST -------
(From update of attachment 138487 [details])
Attachment 138487 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12523103
------- Comment #4 From 2012-04-23 19:45:39 PST -------
(In reply to comment #3)
> (From update of attachment 138487 [details] [details])
> Attachment 138487 [details] [details] did not pass mac-ews (mac):
> Output: http://queues.webkit.org/results/12523103

Unrelated. Something is up with the bot.
------- Comment #5 From 2012-04-23 22:49:29 PST -------
(From update of attachment 138487 [details])
What's good for the field must be good for the method!
------- Comment #6 From 2012-04-23 23:51:59 PST -------
> What's good for the field must be good for the method!

Yep. I did not do the method cache right away because of https://bugs.webkit.org/show_bug.cgi?id=84668
------- Comment #7 From 2012-04-24 00:00:20 PST -------
Created an attachment (id=138502) [details]
Patch for landing
------- Comment #8 From 2012-04-24 00:48:41 PST -------
(From update of attachment 138502 [details])
Clearing flags on attachment: 138502

Committed r115007: <http://trac.webkit.org/changeset/115007>
------- Comment #9 From 2012-04-24 00:48:45 PST -------
All reviewed patches have been landed.  Closing bug.