Bug 84663 - [V8] Pass Isolate around in SerializedScriptValue.cpp (Part1)
Summary: [V8] Pass Isolate around in SerializedScriptValue.cpp (Part1)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 84074
  Show dependency tree / graph
 
Reported: 2012-04-23 18:14 PDT by Kentaro Hara
Modified: 2012-04-24 10:01 PDT (History)
3 users (show)

See Also:

Attachments
Patch (8.85 KB, patch)
2012-04-23 18:17 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-04-23 18:14:33 PDT 
The objective is to pass Isolate to toV8() in SerializedScriptValue.cpp.

Part1: Add an Isolate argument to SerializedScriptValue::create(), SerializedScriptValue::deserialize(), etc
Part2: Add an m_isolate member to SerializedScriptValue::Writer() and SerializedScriptValue::Reader()
Part3: Pass Isolate to toV8().

In this bug, we fix Part1.
Comment 1 Kentaro Hara 2012-04-23 18:17:36 PDT 
Created attachment 138481 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-24 10:01:47 PDT 
Comment on attachment 138481 [details]
Patch

Clearing flags on attachment: 138481

Committed r115077: <http://trac.webkit.org/changeset/115077>
Comment 3 WebKit Review Bot 2012-04-24 10:01:54 PDT 
All reviewed patches have been landed.  Closing bug.