Bug 84647 - Oscillator::setWaveTable() should not reset oscillator phase
Summary: Oscillator::setWaveTable() should not reset oscillator phase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-23 15:59 PDT by Chris Rogers
Modified: 2012-04-23 20:19 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.20 KB, patch)
2012-04-23 16:01 PDT, Chris Rogers 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2012-04-23 15:59:49 PDT 
Oscillator::setWaveTable() should not reset oscillator phase
Comment 1 Chris Rogers 2012-04-23 16:01:28 PDT 
Created attachment 138448 [details]
Patch
Comment 2 Kenneth Russell 2012-04-23 16:05:01 PDT 
Comment on attachment 138448 [details]
Patch

Looks straightforward. Layout test?
Comment 3 Chris Rogers 2012-04-23 16:08:33 PDT 
Comment on attachment 138448 [details]
Patch

Thanks Ken.  Unfortunately, this is quite difficult to test since it involves the main thread calling setWaveTable() while the audio thread is rendering, and this is racy as far as layout tests go.
Comment 4 WebKit Review Bot 2012-04-23 20:19:55 PDT 
Comment on attachment 138448 [details]
Patch

Clearing flags on attachment: 138448

Committed r114988: <http://trac.webkit.org/changeset/114988>
Comment 5 WebKit Review Bot 2012-04-23 20:19:59 PDT 
All reviewed patches have been landed.  Closing bug.