Bug 84644 - WaveTable should normalize to 0dbFS instead of -6dbFS
Summary: WaveTable should normalize to 0dbFS instead of -6dbFS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-23 15:39 PDT by Chris Rogers
Modified: 2012-04-24 14:20 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.38 KB, patch)
2012-04-23 15:42 PDT, Chris Rogers
kbr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2012-04-23 15:39:02 PDT
WaveTable should normalize to 0dbFS instead of -6dbFS
Comment 1 Chris Rogers 2012-04-23 15:42:46 PDT
Created attachment 138441 [details]
Patch
Comment 2 Chris Rogers 2012-04-23 15:43:53 PDT
The Web Audio API spec:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#dfn-createWaveTable

says that createWaveTable() normalizes to 0dbFS
Comment 3 Kenneth Russell 2012-04-23 16:07:25 PDT
Comment on attachment 138441 [details]
Patch

OK. Would it make sense to rebaseline the tests in this patch?
Comment 4 Chris Rogers 2012-04-23 16:10:13 PDT
I was planning to land the patch manually, and then use "garden-o-matic" to re-baseline all platforms once the new baselines become available.
Comment 5 Chris Rogers 2012-04-24 14:20:29 PDT
Committed r115111: <http://trac.webkit.org/changeset/115111>